Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add labeller and labels script #1392

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

Tchoupinax
Copy link
Collaborator

@Tchoupinax Tchoupinax commented Dec 15, 2024

No description provided.

@Tchoupinax Tchoupinax requested a review from a team as a code owner December 15, 2024 20:38
@coveralls
Copy link
Collaborator

coveralls commented Dec 15, 2024

Pull Request Test Coverage Report for Build 12465236796

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 75.437%

Files with Coverage Reduction New Missed Lines %
server/src/streaming/systems/personal_access_tokens.rs 1 82.4%
Totals Coverage Status
Change from base Build 12464784508: -0.003%
Covered Lines: 24296
Relevant Lines: 32207

💛 - Coveralls

spetz
spetz previously approved these changes Dec 15, 2024
spetz
spetz previously approved these changes Dec 15, 2024
hubcio
hubcio previously approved these changes Dec 17, 2024
Copy link
Collaborator

@hubcio hubcio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, could you please add a validator, which would block if Cargo.toml in server or sdk is changed, but version is not bumped?

for example someone changed deps, but forgot to bump version in this toml, make it another verification in sanity.yml

@@ -0,0 +1,23 @@
name: Relabelling
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it start with r to match rest of workflows in this project, same for line 7

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both done :)

@Tchoupinax
Copy link
Collaborator Author

also, could you please add a validator, which would block if Cargo.toml in server or sdk is changed, but version is not bumped?

Will be part of next CI's updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants