Improve materialize_batch_and_maybe_update_state #1381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor materialize_batch_and_maybe_update_state to use drain for processing message batches, eliminating unnecessary copies of self.messages and enhancing performance.
Iggy bench results for messages_required_to_save = 1(via
cargo run --release --bin iggy-bench -- send tcp
)new function:
old:
messages_required_to_save=5000:
new
old:
The new function significantly improves performance for low values of messages_required_to_save, especially in throughput and latency. For higher values, the performance gap narrows