Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return remaining messages in batch when auto commit is disabled #1375

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Return remaining messages in batch when auto commit is disabled #1375

merged 1 commit into from
Dec 4, 2024

Conversation

spetz
Copy link
Collaborator

@spetz spetz commented Dec 4, 2024

No description provided.

@spetz spetz added improvement A change that improves our (or users) QoL sdk Change related to sdk (client) API labels Dec 4, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12156206011

Details

  • 0 of 12 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.009%) to 75.093%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sdk/src/clients/consumer.rs 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
server/src/quic/listener.rs 1 83.33%
sdk/src/clients/consumer.rs 1 0.0%
Totals Coverage Status
Change from base Build 12106595517: -0.009%
Covered Lines: 23167
Relevant Lines: 30851
💛 - Coveralls

@spetz spetz merged commit 733037c into master Dec 4, 2024
16 of 17 checks passed
@spetz spetz deleted the sdk_update branch December 4, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubcio hubcio hubcio approved these changes

Assignees

@hubcio hubcio

@BartoszCiesla BartoszCiesla

@numinnex numinnex

Labels
improvement A change that improves our (or users) QoL sdk Change related to sdk (client) API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spetz @coveralls @hubcio @BartoszCiesla @numinnex