Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Index and TimeIndex into single Index #1313

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

hubcio
Copy link
Collaborator

@hubcio hubcio commented Oct 26, 2024

No description provided.

@hubcio hubcio force-pushed the consolidate_indices branch 3 times, most recently from 9c4550e to e9fb383 Compare October 26, 2024 12:11
@hubcio hubcio force-pushed the consolidate_indices branch 3 times, most recently from 6b6bf72 to c461f6c Compare October 27, 2024 11:47
@coveralls
Copy link
Collaborator

coveralls commented Oct 27, 2024

Pull Request Test Coverage Report for Build 11601949285

Details

  • 74 of 184 (40.22%) changed or added relevant lines in 14 files are covered.
  • 8 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+1.0%) to 75.167%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/src/channels/commands/maintain_messages.rs 0 1 0.0%
server/src/compat/storage_conversion/mod.rs 0 1 0.0%
server/src/streaming/segments/index.rs 23 24 95.83%
server/src/streaming/storage.rs 0 1 0.0%
server/src/streaming/partitions/messages.rs 7 12 58.33%
server/src/streaming/partitions/storage.rs 7 14 50.0%
server/src/streaming/segments/storage.rs 11 29 37.93%
server/src/compat/index_conversion/index_converter.rs 9 85 10.59%
Files with Coverage Reduction New Missed Lines %
server/src/streaming/systems/messages.rs 1 69.7%
sdk/src/clients/client.rs 1 71.11%
server/src/quic/listener.rs 1 83.33%
server/src/streaming/segments/storage.rs 1 48.47%
server/src/streaming/systems/users.rs 1 88.15%
server/src/streaming/partitions/messages.rs 3 83.16%
Totals Coverage Status
Change from base Build 11515054931: 1.0%
Covered Lines: 22759
Relevant Lines: 30278

💛 - Coveralls

@hubcio hubcio force-pushed the consolidate_indices branch 2 times, most recently from 871229c to a9ca65e Compare October 27, 2024 14:04
@hubcio hubcio requested a review from a team as a code owner October 27, 2024 14:04
@hubcio hubcio force-pushed the consolidate_indices branch 9 times, most recently from d9e9481 to a8228ac Compare October 30, 2024 21:14
@hubcio hubcio force-pushed the consolidate_indices branch from a8228ac to ae13b1c Compare October 30, 2024 21:28
@hubcio hubcio merged commit 5fb550d into master Nov 3, 2024
17 checks passed
@hubcio hubcio deleted the consolidate_indices branch November 3, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants