Release 3.2.0 #107
Release 3.2.0 #107
Conversation
lib/Route.js
Outdated
| @@ -31,7 +31,7 @@ Route.createRoute = function (patternConfig, schema, handlers, openApiDocs) { | |||
| // Validate the schema | |||
| var isSchemaValid = validateSchema(schema); | |||
| if (!isSchemaValid) { | |||
| throw new Error("Invalid schema"); | |||
| throw new Error("Invalid schema" + JSON.stringify(schema)); // TODO revert | |||
There was a problem hiding this comment.
This is to help debugging for now?
There was a problem hiding this comment.
Reverted, I was looking into the failure from updating the jsen patch version
| ===== | ||
|
|
||
| + Drop support for Node.js < 12. | ||
| + Hold back jsen dependency. See https://github.com/ifwe/monocle-api/issues/86 |
There was a problem hiding this comment.
why go to 4.0.0 now, if we're holding off on the breaking change?
There was a problem hiding this comment.
Fixed, any applications that had failures due to using older Node.js versions should be pretty obvious, so a major version bump shouldn't be needed for that. The package.json "engines" change added after this also makes this obvious
TysonAndre
force-pushed
the
release-4.0.0
branch
4 times, most recently
from
1fd0d91
to
b3768af
Compare
Start setting up (failing) eslint rules Fix some occurrences of unused variables and harmless uses of hasOwnProperty (in hardcoded schema) Set up github workflows Drop use of bluebird because Node.js has efficient native Promises. Update CHANGELOG.md
TysonAndre
force-pushed
the
release-4.0.0
branch
from
b3768af
to
87791bf
Compare
|
No release of I haven't looked into the impact of switching to |
|
lgtm |
Start setting up (failing) eslint rules
Fix some occurrences of unused variables and harmless uses of
hasOwnProperty (in hardcoded schema)
Set up github workflows
Drop use of bluebird because Node.js has efficient native Promises.
Update CHANGELOG.md
Hold back jsen dependency. See #86