Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component] Resource #783

Closed
nshki opened this issue Jan 9, 2018 · 7 comments
Closed

[Component] Resource #783

nshki opened this issue Jan 9, 2018 · 7 comments

Comments

@nshki
Copy link
Member

nshki commented Jan 9, 2018

Overview

We are looking for an awesome human to build this out as a React component, preferably within Storybook. You can view and get details (colors, dimensions, export SVGs, etc.) by visiting the Figma designs and creating a free account.

This is part of the app redesign (#691). This also will incorporate another component #782.

Screenshot from the Figma document:

screenshot 2018-01-09 at 6 24 47 pm

@nshki nshki added the design label Jan 9, 2018
@Seunadex
Copy link
Collaborator

Seunadex commented Feb 22, 2018

@nshki @julianguyen Kindly give more clarity to this, i seems not to fully get how it should be implemented?

@nshki
Copy link
Member Author

nshki commented Feb 23, 2018

Just as a public FYI, we had a discussion regarding the above question over Slack. The Figma mockup of the resources page was referenced for context.

@baohouse
Copy link
Contributor

@nshki Is it the case that the tags and the author are optional, and that it's possible to have:

  1. both visible
  2. tags visible only
  3. author visible only
  4. neither visible

@Seunadex
Copy link
Collaborator

From what I'm aware of, it is either the tags or the author which is the only difference between the two components, @nshki can do more justice to that.

@baohouse
Copy link
Contributor

@nshki For this component, is author and tags mutually exclusive, or can both exist simultaneously?

@nshki
Copy link
Member Author

nshki commented Mar 28, 2018

@baohouse In the designs I only used the tags for external resources and authors for internal ones, but it makes sense to be able to have both tags and authors co-exist. Sorry about the late reply, by the way!

@Seunadex
Copy link
Collaborator

Seunadex commented Apr 7, 2018

This is completed and can be closed now

@Seunadex Seunadex closed this as completed Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants