sub menu for "Moments" doesn't disappear as intended

[andy5995]

Possible (very) minor bug

Should the sub menu for "Moments' disappear when the mouse is moved to a different top-level menu item?

I see the links for "Categories" and "Moods" (under the top-level "Moments" by default) even after the mouse is moved to different top-level menu items. Those two links disappear only after the mouse cursor is moved outside the navigation panel.

I'm using Firefox 55.0.3 on Debian Linux 9.

[julianguyen]

This is what the experiences looks like for me:

Hovering away from the entire navigation menu, including the expanded menu with "Categories" and "Moods" causes the menu to close.

So the behaviour you're describing is intended, but we're totally open to changing it if it's not intuitive. Thoughts? :D

[andy5995]

But see what happens if you hover the mouse on moments, then go directly to the right and hover on strategies... Sent using Zoho Mail

…

---- On Mon, 04 Sep 2017 22:28:15 -0700 [email protected] wrote ---- This is what the experiences looks like for me: Hovering away from the entire navigation menu, including the expanded menu with "Categories" and "Moods" causes the menu to close. So the behaviour you're describing is intended, but we're totally open to changing it if it's not intuitive. Thoughts? :D — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[julianguyen]

Ohhh I see what you're saying!

Ooh yes, this would be a bug.

Intended Behaviour

1. However over Moments link
2. Expanded menu with Categories and Moods appears
3. Hovering away from the navigation menu closes it OR hovering over another navigation menu item other than Moments closes it

Would you be interested in fixing this @andy5995? :D

[andy5995]

I'll pass on this one, Julia. I'm not too good with CSS.

[baohouse]

I had hoped this be a trivial fix, but an initial glance at header.js made me cry at how WET it is (i.e. not DRY). Let me take a stab at this.

[HashNotAdam]

@baohouse literally? 🔪 🔪 🔪

[baohouse]

I'm guessing this shouldn't be possible either.

[julianguyen]

@baohouse Yeah that shouldn't be possible. Definitely a bug lol

[HashNotAdam]

@julianguyen @baohouse can I just take a moment to step back?

To be very honest, I've never liked that menu; not only does it create a jarring experience for me but I have concerns that it could create anxiety for people who suffer from certain cognitive disabilities.

What about throwing out the JavaScript completely, use CSS, and allow the subitems to be positioned over the body so the content doesn't move up and down?

[julianguyen]

Feel free to redesign it yeeeeee.

[ghost]

oops! I just sent in a suggestion about this with my google forms submission. glad to see it's being worked on! (sorry for a trivial little comment!)

[andy5995]

It's the thought that counts, @zx-wolftaur ; Thanks!

[baohouse]

So now I wonder how #691 is going to affect this issue. I could churn out a rewrite of the header as a React component based on the existing look, but given that this issue really has a low impact (it's not a terrible experience), should we focus on the app redesign efforts instead?

[zawmoelwin]

If the redesign will take a while, I am open to be assigned on this issue.

[baohouse]

@zawmoelwin If it helps with getting acclimated to the new React codebase, sure, you can work on it. There's a Logo.jsx that you can use as a starting point.