Make the checksum optional #511
Conversation
There was a problem hiding this comment.
In principle I have no objection to the checksum being optional, but I think we should figure out a way to signal to the Helper at aggregation time that the the checksum will be requested later at collection time. I explain below.
The checksum is designed so that the order of reports doesn't matter: if both Aggregators have the same set of reports in the batch, then the checksums will match and collection will succeed. This means that we can either compute it as we go at aggregation time or wait until collection time and compute it all at once. The former is strictly better because we already have the report IDs in memory during aggregation time, whereas if we wait until collection time, we'd have to make a bunch of database queries to look up the report IDs in the batch.
Computing it aggregation time is always better I think. If the Helper does not know whether the checksum will be requested, I suspect it'll always want to compute it ahead of time just in case.
We can avoid this by signaling ahead of time that the checksum will be requested. One way to do this would be to add the signal to the task config.
|
Putting that signal in the task config seems like it'd work! |
|
Closing per discussion at IETF 118. |
Closes #446