Inline {{aggregation-job-validation}} into the sections that reference it
#473
Labels
Comments
tgeoghegan
added a commit
that referenced
this issue
Jun 27, 2023
The section describing how the Leader validates an `AggregationJobResp` only contained a single criteria, and referring to it from multiple places made it unnecessarily complicated. We now simply restate the singular requirement in two sections, which should make this more clear for implementers. Resolves #473
cjpatton
pushed a commit
that referenced
this issue
Jul 4, 2023
The section describing how the Leader validates an `AggregationJobResp` only contained a single criteria, and referring to it from multiple places made it unnecessarily complicated. We now simply restate the singular requirement in two sections, which should make this more clear for implementers. Resolves #473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
{{aggregation-job-validation}}is referenced from the leader initialization and leader continuation sections. We did this to "factor out" common bits of protocol logic into a single place. However it only contains a single requirement, so on balance it probably does more harm to readability than it does improve maintainability of the document. We should inline that single bullet point into the sections that reference it.See previous discussion.
The text was updated successfully, but these errors were encountered: