removed dashes - as valid characters for dot-name selectors
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IIRC (and it's a big if given how long ago I made a change), you don't need to check in generated files. Indeed |
mkmik
approved these changes
May 11, 2021
goessner
approved these changes
May 19, 2021
cabo
approved these changes
May 19, 2021
| @@ -592,7 +592,6 @@ selector = dot-child ; see below for alternatives | |||
| dot-child = "." dot-child-name / ; .<dot-child-name> | |||
| "." "*" ; .* | |||
| dot-child-name = 1*( | |||
| "-" / ; - | |||
There was a problem hiding this comment.
In a separate PR, we should remove all those redundant comments.
Closed
glyn
approved these changes
Jun 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16
Also, I'm not sure what needs to be included in the PR as far as generated files go. Any guidance would be helpful.