Various nits on #129, #131 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goessner
reviewed
Nov 4, 2021
| string-literal | ||
| in-op = " in " ; in operator | ||
| in-op = RS "in" RS ; in operator |
There was a problem hiding this comment.
yes, I was stumbeling over that also ...
goessner
reviewed
Nov 4, 2021
| union-selector / | ||
| slice-selector / | ||
| descendant-selector / | ||
| filter-selector)) |
There was a problem hiding this comment.
Do we really want to allow jsonpathes scattered across several lines
$ . a
[ 'b' ]
[ 123 ]
Has there been users demand for this ?
There was a problem hiding this comment.
You mean, allowing newlines in JSONPath? Depends a bit on how long they are. I seem to remember we wanted to be lenient here...
There was a problem hiding this comment.
yes i can remember darkly too ... so your edits all in all make sense.
goessner
reviewed
Nov 4, 2021
| @@ -779,16 +783,19 @@ It selects elements starting at index `<start>`, ending at — but | |||
| not including — `<end>`, while incrementing by `step`. | |||
|
|
|||
| ~~~~ abnf | |||
| slice-selector = "[" S [start S] ":" [ S end] [S ":" S [step]] S "]" | |||
| slice-selector = "[" S [start S] ":" S [end S] [":" S [step S]] "]" | |||
There was a problem hiding this comment.
definitely better now ...
goessner
reviewed
Nov 4, 2021
| %x0D ; Carriage return | ||
| S = *B ; optional blank space | ||
| RS = 1*B ; required blank space | ||
|
|
There was a problem hiding this comment.
yes ... needed once for now ...
goessner
reviewed
Nov 4, 2021
| @@ -997,7 +1004,7 @@ as many times in the node list. | |||
| The filter selector has the form `[?<expr>]`. It works via iterating over structured values, i.e. arrays and objects. | |||
|
|
|||
| ~~~~ abnf | |||
| filter-selector = "[?" S boolean-expr S "]" | |||
| filter-selector = "[" S "?" S boolean-expr S "]" | |||
There was a problem hiding this comment.
hmm ... consistent with blank philosophy above though
goessner
approved these changes
Nov 4, 2021
This was referenced Nov 9, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of niggly details re blank space.
Style consistency, some missing places (assuming we stick with the liberal approach).
Allowing "in" before or after a newline or tab.
Adding some legend to the only remaining table with XPath content in the main document.