Provide proper Triples explaination #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogeshbdeshpande
force-pushed
the
triples-explaination
branch
from
506d1d2
to
0239db4
Compare
yogeshbdeshpande
requested review from
henkbirkholz,
thomas-fossati and
nedmsmith
as code owners
yogeshbdeshpande
changed the title
deeglaze
reviewed
Nov 1, 2024
deeglaze
requested changes
Nov 1, 2024
deeglaze
reviewed
Nov 6, 2024
deeglaze
reviewed
Nov 11, 2024
deeglaze
approved these changes
Nov 13, 2024
henkbirkholz
approved these changes
Nov 13, 2024
deeglaze
reviewed
Nov 13, 2024
|
@nedmsmith, @thomas-fossati and @andrew-draper Kindly review the same, as discussed during the review! |
draft-ietf-rats-corim.md
Outdated
| If the search criteria are satisfied, the matching entry is re-asserted, except with the Reference Value Provider's authority. | ||
| By re-asserting Evidence using the RVP's authority, the Verifier can avoid mixing Reference Values (reference state) with Evidence (actual state). | ||
| See {{-rats-endorsements}}. | ||
| Re-asserted Evidence using RVP authority is said to be "corroborated". | ||
|
|
||
| #### Endorsed Values Triple {#sec-comid-triple-endval} | ||
|
|
||
| [^issue] https://github.com/ietf-rats-wg/draft-ietf-rats-corim/issues/310 | ||
| An Endorsed Values triple provides additional Endorsements for an existing Target Environment. | ||
| For Endorsed Values Claims, the _subject_ is a Target Environment, the _object_ contains Endorsement Claims for the Environment, and the _predicate_ defines semantics for how the _object_ relates to the _subject_. |
There was a problem hiding this comment.
unclear why _ is used here (and not in the ref-value triple explainer)
draft-ietf-rats-corim.md
Outdated
| @@ -1151,7 +1156,8 @@ The new entry is added to the existing set of entries using the Endorser's autho | |||
|
|
|||
| #### Conditional Endorsement Triple {#sec-comid-triple-cond-endors} | |||
|
|
|||
| [^issue] https://github.com/ietf-rats-wg/draft-ietf-rats-corim/issues/310 | |||
| A Conditional Endorsement Triple declares one or more conditions that, once they match, cause every entry in the endorsements to be added to the accepted state. | |||
There was a problem hiding this comment.
have we already defined "accepted state" at this point? If not, I suggest using a more intelligible term (e.g., actual state, as per I-D.ietf-rats-endorsements)
draft-ietf-rats-corim.md
Outdated
|
|
||
| The series object is an array of `conditional-series-record` that has both Reference and Endorsed Values. | ||
| Each conditional-series-record record is evaluated in the order it appears in the series array. | ||
| The Endorsed Values are accepted if the series condition in a `conditional-series-record` matches the ACS. |
There was a problem hiding this comment.
This one too seems too deep too soon: reference to internals, mention of ACS.
There was a problem hiding this comment.
We can change ACS to attester's actual state
There was a problem hiding this comment.
The triple is hard to explain with out the context of ACS, The matching semantics needs ACS. Few alternatives below:
- Forward reference to ACS and request reader to understand ACS before arriving here!
- Change ACS to attester's actual state. Tried but does not improve the situation dramatically, infact matching on attester's actual state yield more ambIguity!
draft-ietf-rats-corim.md
Outdated
Comment on lines
1185
to
1186
| The first `conditional-series-record` that successfully matches an ACS Entry terminates the matching and the corresponding Endorsed Values are accepted. | ||
| If none of the series conditions match an ACS Entry, the triple is not matched, and no Endorsed values are accepted. |
draft-ietf-rats-corim.md
Outdated
| @@ -1151,7 +1156,8 @@ The new entry is added to the existing set of entries using the Endorser's autho | |||
|
|
|||
| #### Conditional Endorsement Triple {#sec-comid-triple-cond-endors} | |||
|
|
|||
| [^issue] https://github.com/ietf-rats-wg/draft-ietf-rats-corim/issues/310 | |||
| A Conditional Endorsement Triple declares one or more conditions that, once they match, cause every entry in the endorsements to be added to the accepted state. | |||
There was a problem hiding this comment.
Suggested change
| A Conditional Endorsement Triple declares one or more conditions that, once they match, cause every entry in the endorsements to be added to the accepted state. | |
| A Conditional Endorsement Triple declares one or more conditions that, once they match, cause every entry in the endorsements to be added to the actual state. |
deeglaze
reviewed
Nov 20, 2024
henkbirkholz
approved these changes
Nov 20, 2024
thomas-fossati
approved these changes
Nov 20, 2024
nedmsmith
approved these changes
Nov 20, 2024
Fixes #310 Signed-off-by: Yogesh Deshpande <[email protected]>
Add suggestions from Ned and Dionna Co-authored-by: Dionna Amalie Glaze <[email protected]> Co-authored-by: Ned Smith <[email protected]>
Signed-off-by: Yogesh Deshpande <[email protected]>
Apply simple edits that improve the language of the draft! Co-authored-by: Thomas Fossati <[email protected]> Co-authored-by: Dionna Amalie Glaze <[email protected]>
Co-authored-by: Ned Smith <[email protected]>
Co-authored-by: Dionna Amalie Glaze <[email protected]> Co-authored-by: Thomas Fossati <[email protected]>
yogeshbdeshpande
force-pushed
the
triples-explaination
branch
from
58bfa5d
to
ced1a30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #310