Extensibility section updated #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added text to extensibility section - see issue #10
nedmsmith
requested review from
henkbirkholz,
thomas-fossati and
yogeshbdeshpande
as code owners
draft-ietf-rats-corim.md
Outdated
| @@ -1194,7 +1195,22 @@ applies to all measurements in the triple, including those in `measurement-value | |||
|
|
|||
| ## Extensibility {#sec-extensibility} | |||
|
|
|||
| [^issue] https://github.com/ietf-rats-wg/draft-ietf-rats-corim/issues/10 | |||
| CoRIM is described using CDDL {{-cddl}} which includes extensibility support for "sockets" (a.k.a., map structures) | |||
| and data types. CDDL socket extensions have the form `($$NAME-extension)` where "NAME" is the name of the map. | |||
There was a problem hiding this comment.
$$foo is a an extension point for a group-choice
$bar is an extension point for a type-choice
Not sure if that level of detail is relevant here, but that is less ambiguous to me.
There was a problem hiding this comment.
@henkbirkholz to work on this PR
draft-ietf-rats-corim.md
Outdated
| Well-known code points may be in a registry, such as CoSWID {{-coswid-reg}}. | ||
| Additionally, a range of code points may be reserved for vendor-specific use such as negative integers. | ||
|
|
||
| Data type extensibility has the form `($NAME-type-choice)` where "NAME" is the type name and '$' signifies type extensibility. |
There was a problem hiding this comment.
Ah. Here we go. I'd move the referrals and definitions to type- and group-choice to the top. And come back to it here.
henkbirkholz
requested changes
Aug 16, 2023
Co-authored-by: Henk Birkholz <[email protected]>
nedmsmith
commented
Sep 14, 2023
replace socket with extension points
replace socket with extension point
replace socket with map
draft-ietf-rats-corim.md
Outdated
| @@ -1239,7 +1240,22 @@ applies to all measurements in the triple, including those in `measurement-value | |||
|
|
|||
| ## Extensibility {#sec-extensibility} | |||
|
|
|||
| [^issue] https://github.com/ietf-rats-wg/draft-ietf-rats-corim/issues/10 | |||
| CoRIM is described using CDDL {{-cddl}} which includes extensibility support for "extension points" (a.k.a., map structures) | |||
There was a problem hiding this comment.
The whole structure of the section needs reorganising. I will suggest a better rewrite as an edit to this section!
henkbirkholz
approved these changes
Sep 27, 2023
andrew-draper
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added text to extensibility section - see issue #10