raw values type #120
Merged
raw values type #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added text to the Raw Values Type section. Fixes issue #9
nedmsmith
requested review from
henkbirkholz,
thomas-fossati and
yogeshbdeshpande
as code owners
| Raw value measurements are typically vendor defined values that are checked by Verifiers | ||
| for consistency only, since the security relevance is opaque to Verifiers. | ||
|
|
||
| There are two parts to a `raw-value-group`, a measurement and an optional mask. |
There was a problem hiding this comment.
optional mask
Just looking at this PR and not the whole document: is it clear what mask means here?
There was a problem hiding this comment.
issue #9 will be worked further
| between the various forms. | ||
|
|
||
| The mask is applied by the Verifier as part of appraisal. | ||
| Only the raw value bits with corresponding TRUE mask bits are compared during appraisal. |
There was a problem hiding this comment.
See above. Does this text lead to implementable behavior?
Co-authored-by: Henk Birkholz <[email protected]>
yogeshbdeshpande
approved these changes
Aug 16, 2023
andrew-draper
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added text to the Raw Values Type section. Fixes issue #9, partially