Refactor ThermalEnergyDemand #918
Conversation
danielfeismann
added
enhancement
There was a problem hiding this comment.
Thanks for pushing this further, @marvinheintze! Also a good idea to add the cases for negative demands. I thought a bit on this and I guess it will be easier to go just with positive demands as we at the moment doesn't have any specific use case that requires negative demands. So please remove them again, I'm sorry for the confusion that may arised.
| if ( | ||
| math.abs(possible.toKilowattHours) < math.abs( | ||
| required.toKilowattHours | ||
| ) && math.signum(possible.toKilowattHours) <= math.signum( | ||
| required.toKilowattHours | ||
| ) | ||
| ) |
There was a problem hiding this comment.
If possible would be -2 and required 1 this would not throw an exception, or am I wrong?
Lets go with just positive values (at least for now). So it would be great to check first if req or pos is negative plus if possible is smaller than required. In any case we should throw an an InvalidParameterException with a suitable message.
resolves #917
I started here, but more needs to be done. Feel free to take over :)