Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ThermalGridDemand #917

Open
5 tasks
danielfeismann opened this issue Aug 21, 2024 · 0 comments · May be fixed by #918
Open
5 tasks

Refactor ThermalGridDemand #917

danielfeismann opened this issue Aug 21, 2024 · 0 comments · May be fixed by #918
Assignees
Labels
enhancement New feature or request HiWiStart Good for New HiWis

Comments

@danielfeismann
Copy link
Member

danielfeismann commented Aug 21, 2024

In my opinion the ThermalGridDemand should

  • also be able to use for negative values to show some 'production'

Definitions in ScalaDoc state required as the absolutely required demand and possible for the maximum demand. We named it additionalDemand later, which is a bit misleading. In my point of view we should use it in the meaning of min and max. Thus

  • def hasAdditionalDemand should check if possible > zero not > required
  • Optional: Maybe some functions for hasRequiredNegativeDemand (maybe find a better wording) make sense?
  • ... more ... ?

Not sure about:

  • We should throw an exception if possible < required or at least think if the actual solution to set ThermalDemand to (possible, possible) always make sense and is what we expect..

I started but maybe someone would take over this

@danielfeismann danielfeismann added enhancement New feature or request HiWiStart Good for New HiWis labels Aug 21, 2024
@danielfeismann danielfeismann linked a pull request Aug 21, 2024 that will close this issue
danielfeismann added a commit that referenced this issue Aug 21, 2024
…ermalEnergyDemand' into df/#827_fix_hp_storage_refill
@marvinheintze marvinheintze self-assigned this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request HiWiStart Good for New HiWis
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants