New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider `None`-equivalent value for missing data points in weather #188

Open

sebastian-peter opened this issue Apr 6, 2022 · 1 comment · May be fixed by #417

Assignees

Labels

question

Member

sebastian-peter commented Apr 6, 2022

When no weather data is present for a coordinate/time combination, specific values (e.g. 0°K for empty temperature) are provided.

simona/src/main/scala/edu/ie3/simona/service/weather/WeatherSource.scala

Lines 513 to 518 in ad824fc

    
           val EMPTY_WEATHER_DATA: WeatherData = WeatherData( 
        
             Quantities.getQuantity(0d, StandardUnits.SOLAR_IRRADIANCE), 
        
             Quantities.getQuantity(0d, StandardUnits.SOLAR_IRRADIANCE), 
        
             Quantities.getQuantity(0d, Units.KELVIN).to(StandardUnits.TEMPERATURE), 
        
             Quantities.getQuantity(0d, StandardUnits.WIND_VELOCITY) 
        
           )

We should have a discussion on whether this is the best way to solve this, in contrast to passing on None (or equivalent) to SPAs.

The text was updated successfully, but these errors were encountered:

sebastian-peter added the question label

staudtMarius self-assigned this

staudtMarius linked a pull request

that will close this issue

Consider-none-equivalent-value-for-missing-data-pints-in-weather #417

Open

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

b503f06

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

81cd8ac

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge remote-tracking branch 'origin/ms/#188-consider-none-equivalent…

067bde1

…-value-for-missing-data-pints-in-weather' into ms/#188-consider-none-equivalent-value-for-missing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

12b093b

…ssing-data-pints-in-weather

Contributor

t-ober commented Jan 18, 2023

@staudtMarius we should also log that we do not get any weather data for the specified time. This makes debugging much easier.

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

4f39991

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

a27d82a

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

1af3dcd

…ssing-data-pints-in-weather

# Conflicts:
#	CHANGELOG.md

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

a265b52

…ssing-data-pints-in-weather

# Conflicts:
#	CHANGELOG.md

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

6e9e3f7

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

de88a70

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

24a95be

…ssing-data-pints-in-weather

# Conflicts:
#	CHANGELOG.md

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

2ae5161

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

11b0fa3

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

21a32bb

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

b07ed65

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

616e784

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

d05b839

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

367175d

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

4e68320

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

369d0d9

…ssing-data-pints-in-weather

# Conflicts:
#	src/main/scala/edu/ie3/simona/ontology/messages/services/WeatherMessage.scala
#	src/main/scala/edu/ie3/simona/service/weather/WeatherSource.scala
#	src/test/scala/edu/ie3/simona/service/weather/WeatherSourceSpec.scala

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

d9b55ba

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

4055ecb

…ssing-data-pints-in-weather

# Conflicts:
#	CHANGELOG.md

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

03504ea

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

6fa3982

…ssing-data-pints-in-weather

# Conflicts:
#	CHANGELOG.md

staudtMarius added a commit that referenced this issue


          Merge remote-tracking branch 'origin/ms/#188-consider-none-equivalent…

303e871

…-value-for-missing-data-pints-in-weather' into ms/#188-consider-none-equivalent-value-for-missing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

8ccb0e2

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

cfe1346

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

360223c

…ssing-data-pints-in-weather

# Conflicts:
#	CHANGELOG.md

staudtMarius added a commit that referenced this issue


          Merge remote-tracking branch 'origin/ms/#188-consider-none-equivalent…

62503bf

…-value-for-missing-data-pints-in-weather' into ms/#188-consider-none-equivalent-value-for-missing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

54d0cd8

…ssing-data-pints-in-weather

# Conflicts:
#	CHANGELOG.md

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

543d496

…ssing-data-pints-in-weather

# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/service/weather/WeatherSource.scala

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

c5db94c

…ssing-data-pints-in-weather

staudtMarius added a commit that referenced this issue


          Merge branch 'dev' into ms/#188-consider-none-equivalent-value-for-mi…

981a3dd

…ssing-data-pints-in-weather

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment