Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement lock status, destroy method and centerContent method #271

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

chenshenhai
Copy link
Member

  • feat(core): implement lock status of Element
  • feat(idraw): add destroy method to end the lifecycle and destroy all associated memory
  • feat(idraw): add centerContent method to render all elements in the center of the view.

@codecov-commenter
Copy link

Codecov Report

Attention: 135 lines in your changes are missing coverage. Please review.

Comparison is base (94927b0) 6.13% compared to head (fe377ae) 5.98%.
Report is 81 commits behind head on main.

Files Patch % Lines
packages/util/src/lib/view-content.ts 0.00% 32 Missing and 3 partials ⚠️
...kages/core/src/middleware/selector/draw-wrapper.ts 0.00% 30 Missing and 2 partials ⚠️
packages/core/src/middleware/selector/index.ts 0.00% 13 Missing and 9 partials ⚠️
packages/util/src/lib/canvas.ts 0.00% 17 Missing and 1 partial ⚠️
packages/idraw/src/idraw.ts 0.00% 7 Missing and 2 partials ⚠️
packages/util/src/lib/controller.ts 0.00% 8 Missing ⚠️
packages/core/src/index.ts 0.00% 3 Missing and 1 partial ⚠️
packages/core/src/middleware/selector/util.ts 0.00% 3 Missing and 1 partial ⚠️
packages/core/src/middleware/selector/config.ts 0.00% 1 Missing ⚠️
packages/renderer/src/loader.ts 0.00% 1 Missing ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #271      +/-   ##
========================================
- Coverage   6.13%   5.98%   -0.16%     
========================================
  Files         77      78       +1     
  Lines       4433    4548     +115     
  Branches     879     893      +14     
========================================
  Hits         272     272              
- Misses      3311    3412     +101     
- Partials     850     864      +14     
Flag Coverage Δ
unittests 5.98% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenshenhai chenshenhai merged commit 21afa9b into main Jan 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants