Move some errors to package level vars. Fix grammar

babyjub/eddsa.go

@@ -6,6 +6,7 @@ package babyjub
 import (
 	"crypto/rand"
 	"database/sql/driver"
+	"errors"
 	"fmt"
 	"math/big"
 
@@ -14,6 +15,13 @@ import (
 	"github.com/iden3/go-iden3-crypto/v2/utils"
 )
 
+var (
+	// ErrVerifyPoseidonFailed BJJ EdDSA (with Poseidon digest) signature verification failed
+	ErrVerifyPoseidonFailed = errors.New("verifyPoseidon failed")
+	// ErrVerifyMimc7Failed BJJ EdDSA (with Mimc7 digest) signature verification failed
+	ErrVerifyMimc7Failed = errors.New("verifyMimc7 failed")
+)
+
 // pruneBuffer prunes the buffer during key generation according to RFC 8032.
 // https://tools.ietf.org/html/rfc8032#page-13
 func pruneBuffer(buf *[32]byte) *[32]byte {
@@ -285,7 +293,7 @@ func (pk *PublicKey) VerifyMimc7(msg *big.Int, sig *Signature) error {
 	if (left.X.Cmp(right.X) == 0) && (left.Y.Cmp(right.Y) == 0) {
 		return nil
 	}
-	return fmt.Errorf("verifyMimc7 failed")
+	return ErrVerifyMimc7Failed
 }
 
 // SignPoseidon signs a message encoded as a big.Int in Zq using blake-512 hash
@@ -334,7 +342,7 @@ func (pk *PublicKey) VerifyPoseidon(msg *big.Int, sig *Signature) error {
 	if (left.X.Cmp(right.X) == 0) && (left.Y.Cmp(right.Y) == 0) {
 		return nil
 	}
-	return fmt.Errorf("verifyPoseidon failed")
+	return ErrVerifyPoseidonFailed
 }
 
 // Scan implements Scanner for database/sql.

babyjub/helpers.go

@@ -20,9 +20,9 @@ func Blake512(m []byte) []byte {
 }
 
 // DecompressSig decompresses a compressed signature.
-func DecompressSig(commpresedSig []byte) (*Signature, error) {
+func DecompressSig(compressedSig []byte) (*Signature, error) {
 	poseidonComSig := &SignatureComp{}
-	if err := poseidonComSig.UnmarshalText(commpresedSig); err != nil {
+	if err := poseidonComSig.UnmarshalText(compressedSig); err != nil {
 		return nil, err
 	}
 	poseidonDecSig, err := poseidonComSig.Decompress()

goldenposeidon/constants.go

@@ -824,7 +824,7 @@ var (
 	M [][]*ffg.Element
 	// P is a matrix
 	P [][]*ffg.Element
-	// S is a array of element
+	// S is an array of element
 	S []*ffg.Element
 )