fix: optimize setZKPRequests implementation #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify setZKPRequests in ValidatorWhitelist, UniversalVerifier, RequestOwnership and EmbeddedZKPVerifier to use super implementation - Remove redundant array iteration logic to prevent potential array bounds issues - Ensure consistent length validation across all verifier contracts - Improve gas efficiency by avoiding duplicate checks This change maintains the same functionality while improving security and reducing code duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed potential optimization opportunities in the
setZKPRequestsimplementation across verifier contracts. I propose modifying the child contracts to directly callsuper.setZKPRequests(), considering:However, this change may affect the original design intent, such as whether child contracts were meant to control their own validation flow. I'd appreciate your confirmation if this approach aligns with the project's design philosophy.
I noticed that EmbeddedZKPVerifier.sol already uses super.setZKPRequests(), while other contracts don't. I'm not sure if this inconsistency was intentional in the original design.
Changes affect:
Thank you for your review!