MCPayment: add erc 20 withdraw #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-basiuk
requested review from
daveroga,
vmidyllic,
Kolezhniuk and
AndriianChestnykh
Pull Request Test Coverage Report for Build 13058217719Details
💛 - Coveralls |
vmidyllic
previously approved these changes
Jan 30, 2025
Kolezhniuk
previously approved these changes
Jan 30, 2025
daveroga
previously approved these changes
Jan 30, 2025
AndriianChestnykh
previously approved these changes
Jan 30, 2025
contracts/payment/MCPayment.sol
Outdated
| function ownerERC20Withdraw(address token) public onlyOwner { | ||
| uint amount = IERC20(token).balanceOf(address(this)); | ||
| if (amount == 0) { | ||
| revert WithdrawError("There is no balance to withdraw"); |
There was a problem hiding this comment.
I would avoid adding strings as custom error params. It may cost more gas. Better change the error name
volodymyr-basiuk
dismissed stale reviews from AndriianChestnykh, daveroga, Kolezhniuk, and vmidyllic
via
0355b46
volodymyr-basiuk
requested review from
vmidyllic,
Kolezhniuk,
AndriianChestnykh and
daveroga
AndriianChestnykh
approved these changes
Jan 30, 2025
daveroga
approved these changes
Jan 31, 2025
vmidyllic
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.