add zero address checking #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndriianChestnykh @daveroga please review and merge if it's ok. |
daveroga
previously approved these changes
Jan 30, 2025
create internal method instead _checkOracleSigningAddress and use custom error error OracleSigningAddressShouldNotBeZero() in it?
AndriianChestnykh
approved these changes
Feb 2, 2025
AndriianChestnykh
requested changes
Feb 2, 2025
There was a problem hiding this comment.
@yushihang Please do the following:
- Cover the unit tests in
cross-chain-proof-validator.tests.ts. You need to cover both constructor and setOracleSigning method. For the method it's simple but for constructor you may need to deploy a validator directly but not viadeployHelper.deployCrossChainProofValidatoror change thedeployHelper.deployCrossChainProofValidatoritself. - Bump the package version in contracts/package.json from 2.5.6 to 2.5.7 (don't confuse with higher level package.json)
daveroga
previously approved these changes
Feb 2, 2025
- Bump package version from 2.5.6 to 2.5.7 - Update test assertions in cross-chain-proof-validator.test.ts to properly handle custom Solidity errors using revertedWithCustomError Technical changes: - Update package.json version - Replace revertedWith with revertedWithCustomError in test cases
@AndriianChestnykh Thank you for your review and detailed advices. I have made the following changes:
Please let me know if anything needs to be tweaked, Thanks! The test results: ❯ npx hardhat test test/cross-chain/cross-chain-proof-validator.test.ts
State Cross Chain
[✓] CrossChainProofValidator deployed to: 0x5FbDB2315678afecb367f032d93F642f64180aa3
✔ Should process the messages without replacedAtTimestamp
✔ Should process the messages with replacedAtTimestamp
✔ Oracle timestamp should not be in the past
✔ Oracle replacedAtTimestamp or oracle timestamp cannot be in the future
✔ Should fail to verify a message which was tampered with
✔ Should fail to verify a message which signature is invalid
Oracle Signing Address Validation
✔ should revert when deploying with zero oracle signing address
[✓] CrossChainProofValidator deployed to: 0x9fE46736679d2D9a65F0992F2272dE9f3c7fa6e0
✔ should deploy with correct parameters
✔ should set a new oracle signing address
✔ should revert when setting oracle signing address to zero
10 passing (2s) |
AndriianChestnykh
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.