#35 Provide additional settings as option files included in playbook #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorobon
approved these changes
Apr 3, 2018
jmonterrubio
reviewed
Apr 3, 2018
defaults/main.yml
Outdated
| @@ -16,6 +16,11 @@ mysql_config_file: /etc/mysql/my.cnf | |||
| mysql_pid_file: /var/run/mysqld/mysqld.pid | |||
| mysql_datadir: /var/lib/mysql | |||
|
|
|||
| # Allowing playbooks to provide external option files | |||
| mysql_extra_conf_include_dir: /etc/mysql/conf.d/ | |||
There was a problem hiding this comment.
i'wd remove the trailing slash, to avoid ugly paths like: "{{ mysql_extra_conf_include_dir }}/test_template.cnf":
jmonterrubio
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Adding the ability to use additional option files in a preconfigured path (defined in default vars)
Benefits
Additional settings could be provided as option files (including templates and files with the playbook)
Applicable Issues
#35