Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical issue with image caching #51

Open
khromov opened this issue Sep 8, 2015 · 6 comments
Open

Critical issue with image caching #51

khromov opened this issue Sep 8, 2015 · 6 comments
Assignees
Milestone

Comments

@khromov
Copy link
Collaborator

khromov commented Sep 8, 2015

After updating to 0.9.1 and trying to add a content card, it went into an infinite loop and started downloading images infinitely. It created 1000 images before I managed to manually stop the web server.

Aside from that, these images were not properly hidden from the media library.

Here's an example:
screen shot 2015-09-08 at 10 24 21

I suggest retracting the 0.9.1 upgrade for now. @ideag

@khromov
Copy link
Collaborator Author

khromov commented Sep 8, 2015

Here's the embed link I used:

http://www.meetup.com/WordPress-Stockholm/?foobar

@ideag
Copy link
Owner

ideag commented Sep 8, 2015

@khromov sorry, but I cannot reproduce this on three of my test sites (localhost, digital ocean droplet and a local Lithuanian VPS).

@ideag
Copy link
Owner

ideag commented Sep 8, 2015

P.S. I see you have not the latest WordPress version. Maybe that's the problem?

@khromov
Copy link
Collaborator Author

khromov commented Sep 8, 2015

I can try to replicate with the same plugins later. The site is running 4.2.4.

I noticed the extensions appear to be cut off. (".jpe")

Anyway, are there any loops that could potentially trigger this behaviour? Maybe we should have some sanity checking to avoid getting into infinite loops?

@ideag
Copy link
Owner

ideag commented Sep 8, 2015

@khromov I don't believe there is a single loop in the code that runs caching. Except maybe in WordPress native functions, but those should not be a problem, too.

@ideag ideag added this to the 0.9.2 milestone Sep 8, 2015
@ideag ideag self-assigned this Sep 14, 2015
@sweethoneycode
Copy link

I had a client come to me with a similar problem. I think what is going on is the old images are not deleting on Cron tasks. It is hosted on SiteGround if that helps.

This was referenced Jan 6, 2017
@ideag ideag modified the milestones: 0.9.6, 1.0.0 Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants