Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ruby, rails and using propshaft, esbuild #395

Open
wants to merge 31 commits into
base: trunk
Choose a base branch
from

Conversation

harshaellanki
Copy link
Contributor

@harshaellanki harshaellanki commented Jul 5, 2024

Updated
Ruby -> 3.0.6
Rails -> 7.0.8.4
Mongoid -> 7.5.4

Removed webpacker and related files.

Loading assets with propshaft and esbuild

Pivotal -> https://www.pivotaltracker.com/n/projects/2640062/stories/187912648

@harshaellanki harshaellanki marked this pull request as ready for review July 8, 2024 18:07
@harshaellanki harshaellanki changed the title WIP: upgrade ruby, rails and using propshaft, esbuild Upgrade ruby, rails and using propshaft, esbuild Jul 9, 2024
@harshaellanki harshaellanki requested review from saipraveen18, saikumar9 and polographer and removed request for saipraveen18 July 9, 2024 16:57
Copy link
Member

@saikumar9 saikumar9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshaellanki Please update the Ruby version for Rubocop in .rubocop.yml.

@saikumar9 saikumar9 self-requested a review July 11, 2024 13:09
@saikumar9 saikumar9 enabled auto-merge (squash) July 11, 2024 13:09
saikumar9
saikumar9 previously approved these changes Jul 11, 2024
Copy link
Member

@saikumar9 saikumar9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job @harshaellanki 🔥

@harshaellanki harshaellanki disabled auto-merge July 12, 2024 17:30
polographer
polographer previously approved these changes Jul 12, 2024
@polographer polographer dismissed stale reviews from saikumar9 and themself via 2f46497 August 16, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants