Fix parse error on medicaid application show (#61)

* switch authentication exclude soap ones

* rubocop

* remove test line

* inherit from application controller

app/controllers/aces/inbound_transfers_controller.rb

@@ -2,8 +2,7 @@
 
 module Aces
   # Transfers from an outside source coming into Enroll
-  class InboundTransfersController < ActionController::Base
-    before_action :authenticate_user!
+  class InboundTransfersController < ApplicationController
     def show
       @transfer = Aces::InboundTransfer.find(params[:id])
       @failure_status = @transfer.failure.nil?

app/controllers/aces/soap/atp_requests_controller.rb

@@ -6,6 +6,7 @@ module Soap
     # system.
     class AtpRequestsController < ApplicationController
       skip_before_action :verify_authenticity_token, only: [:wsdl, :service]
+      skip_before_action :authenticate_user!, only: [:wsdl, :service]
 
       def wsdl
         render "wsdl.wsdl", layout: false, formats: [:wsdl], content_type: "text/xml"

app/controllers/aces/transfers_controller.rb

@@ -2,8 +2,7 @@
 
 module Aces
   # Transfers from Enroll to outside agency
-  class TransfersController < ActionController::Base
-    before_action :authenticate_user!
+  class TransfersController < ApplicationController
     def show
       @transfer = Aces::Transfer.find(params[:id])
       @failure_status = @transfer.failure.nil?

app/controllers/application_controller.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 
 class ApplicationController < ActionController::Base
+  before_action :authenticate_user!
 end

app/controllers/medicaid/applications_controller.rb

@@ -2,10 +2,25 @@
 
 module Medicaid
   # Determinations from MITC
-  class ApplicationsController < ActionController::Base
+  class ApplicationsController < ApplicationController
     def show
       @application = Medicaid::Application.find(params[:id])
+      @application_request_payload = parse_json(@application.application_request_payload)
+      @application_response_payload = parse_json(@application.application_response_payload)
+      @medicaid_request_payload = parse_json(@application.medicaid_request_payload)
+      @medicaid_response_payload = parse_json(@application.medicaid_response_payload)
+      @other_factors = parse_json(@application.other_factors)
       render layout: "application"
     end
+
+    private
+
+    def parse_json(value)
+      return value unless value.present?
+      JSON.parse(value)
+    rescue JSON::ParserError
+      value
+    end
+
   end
 end

app/controllers/reports_controller.rb

@@ -2,7 +2,6 @@
 
 # ReportsController provides API access to reports
 class ReportsController < ApplicationController
-  before_action :authenticate_user!
 
   def events
     @start_on = start_on || session[:start] || Date.today

app/views/medicaid/applications/show.html.erb

@@ -3,16 +3,16 @@
 <p>Processed At: <%= @application.updated_at %></p>
 
 <h2>Application Request Payload:</h2>
-<%= raw(ap(JSON.parse(@application.application_request_payload))) %>
+<%= raw(ap(@application_request_payload)) %>
 <hr>
 <h2>Application Response Payload:</h2>
-<%= raw(ap(JSON.parse(@application.application_request_payload))) %>
+<%= raw(ap(@application_response_payload)) %>
 <hr>
 <h2>Medicaid Request Payload:</h2>
-<%= raw(ap(JSON.parse(@application.medicaid_request_payload))) %>
+<%= raw(ap(@medicaid_request_payload)) %>
 <hr>
 <h2>Medicaid Response Payload:</h2>
-<%= raw(ap(JSON.parse(@application.medicaid_response_payload))) %>
+<%= raw(ap(@medicaid_response_payload)) %>
 <hr>
 <h2>APTC Households</h2>
 <% @application.aptc_households.each do |household| %>
@@ -26,7 +26,7 @@
 <% if @application.other_factors == 'No other factors' %>
   <%= @application.other_factors %>
 <% else %>
-  <%= raw(ap(JSON.parse(@application.other_factors))) %>
+  <%= raw(ap(@other_factors)) %>
 <% end %>
 <hr>
 <%= link_to "Determinations Report", medicaid_application_check_reports_path, class: 'btn btn-primary' %>