Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'double ack'. #49

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Fix 'double ack'. #49

merged 1 commit into from
Jul 11, 2022

Conversation

TreyE
Copy link
Contributor

@TreyE TreyE commented Oct 27, 2021

There is an issue where the same message is acknowledged twice during batching, leading to a listener crash.

saimekala07
saimekala07 previously approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@saimekala07 saimekala07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed redundant ack

@TreyE TreyE changed the base branch from trunk to dc_k8_deployment July 11, 2022 18:20
@TreyE TreyE changed the base branch from dc_k8_deployment to trunk July 11, 2022 18:20
@TreyE TreyE dismissed saimekala07’s stale review July 11, 2022 18:20

The base branch was changed.

@TreyE TreyE merged commit 5112e29 into trunk Jul 11, 2022
@TreyE TreyE deleted the fix_double_batch_ack_hotfix branch July 11, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saimekala07 saimekala07 saimekala07 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TreyE @saimekala07