Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #55 from ideacrew/180365353-fix-missing-terms #187

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

mdkaraman
Copy link
Contributor

@mdkaraman mdkaraman commented Mar 18, 2024

Ticket: TT6-186692128

Note: this PR simply cherry picks a single commit from the me_carrier_boarding branch that corrects a bug in the logic for interpreting events, which was never resolved on trunk.

The problematic scenario occurs when:

  1. An autorenewal enrollment has been generated in coverage_selected state
  2. The autorenewal enrollment moves to unverified
  3. The autorenewal enrollment moves back to coverage_selected
  4. The autorenewal enrollment moves to coverage_canceled

Only the coverage_selected and coverage_canceled events are transmitted to Glue. Since transmissions are sent in batches, these events may occur all within a single batch or be split across multiple batches.

The updates to RemoveSameActionsAndSelectSilent correct the logic when all events are sent in the same batch, while the updates to EnrollmentEventNotification correct the logic when the events are spread across multiple batches.

Original commit message:
Correct missing terminations and incorrect interpretation of events.

Correct missing terminations and incorrect interpretation of events.
@mdkaraman mdkaraman requested review from raghuramg and TreyE March 18, 2024 22:16
Copy link
Contributor

@raghuramg raghuramg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comment, need clarification

@mdkaraman mdkaraman requested a review from raghuramg March 27, 2024 15:23
@mdkaraman mdkaraman enabled auto-merge (squash) March 27, 2024 15:49
Copy link
Contributor

@raghuramg raghuramg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdkaraman mdkaraman merged commit 995083f into trunk Mar 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants