fix: improve applicant destruction confirmation handling and logging #4927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanEddyIC
approved these changes
Jan 14, 2025
bbodine1
force-pushed
the
epic_188588775_csp_enabled
branch
from
d0d2c5e to
9c3a5ba
Compare
bbodine1
force-pushed
the
188690910-faa-applicant-demographics-3
branch
from
820fdbf to
07e5c4f
Compare
bbodine1
force-pushed
the
epic_188588775_csp_enabled
branch
from
9c3a5ba to
d7b3b66
Compare
bbodine1
force-pushed
the
188690910-faa-applicant-demographics-3
branch
from
07e5c4f to
8e5dd3e
Compare
charlienparker
approved these changes
Jan 16, 2025
TreyE
requested changes
Jan 16, 2025
components/financial_assistance/app/views/financial_assistance/applicants/_edit.html.erb
Show resolved
Hide resolved
Comment out console.log Signed-off-by: Brad Bodine <[email protected]>
Signed-off-by: Brad Bodine <[email protected]>
bbodine1
added a commit
that referenced
this pull request
Jan 16, 2025
…4927) * fix: improve applicant destruction confirmation handling and logging * Update financial_assistance.js Comment out console.log Signed-off-by: Brad Bodine <[email protected]> * Update inline_replacements.js Signed-off-by: Brad Bodine <[email protected]> --------- Signed-off-by: Brad Bodine <[email protected]>
bbodine1
added a commit
that referenced
this pull request
Jan 18, 2025
…4927) * fix: improve applicant destruction confirmation handling and logging * Update financial_assistance.js Comment out console.log Signed-off-by: Brad Bodine <[email protected]> * Update inline_replacements.js Signed-off-by: Brad Bodine <[email protected]> --------- Signed-off-by: Brad Bodine <[email protected]>
bbodine1
added a commit
that referenced
this pull request
Jan 23, 2025
…4927) * fix: improve applicant destruction confirmation handling and logging * Update financial_assistance.js Comment out console.log Signed-off-by: Brad Bodine <[email protected]> * Update inline_replacements.js Signed-off-by: Brad Bodine <[email protected]> --------- Signed-off-by: Brad Bodine <[email protected]>
bbodine1
added a commit
that referenced
this pull request
Jan 24, 2025
…4927) * fix: improve applicant destruction confirmation handling and logging * Update financial_assistance.js Comment out console.log Signed-off-by: Brad Bodine <[email protected]> * Update inline_replacements.js Signed-off-by: Brad Bodine <[email protected]> --------- Signed-off-by: Brad Bodine <[email protected]>
bbodine1
added a commit
that referenced
this pull request
Jan 28, 2025
…4927) * fix: improve applicant destruction confirmation handling and logging * Update financial_assistance.js Comment out console.log Signed-off-by: Brad Bodine <[email protected]> * Update inline_replacements.js Signed-off-by: Brad Bodine <[email protected]> --------- Signed-off-by: Brad Bodine <[email protected]>
bbodine1
added a commit
that referenced
this pull request
Jan 31, 2025
…4927) * fix: improve applicant destruction confirmation handling and logging * Update financial_assistance.js Comment out console.log Signed-off-by: Brad Bodine <[email protected]> * Update inline_replacements.js Signed-off-by: Brad Bodine <[email protected]> --------- Signed-off-by: Brad Bodine <[email protected]>
bbodine1
added a commit
that referenced
this pull request
Feb 4, 2025
…4927) * fix: improve applicant destruction confirmation handling and logging * Update financial_assistance.js Comment out console.log Signed-off-by: Brad Bodine <[email protected]> * Update inline_replacements.js Signed-off-by: Brad Bodine <[email protected]> --------- Signed-off-by: Brad Bodine <[email protected]>
bbodine1
added a commit
that referenced
this pull request
Feb 5, 2025
…4927) * fix: improve applicant destruction confirmation handling and logging * Update financial_assistance.js Comment out console.log Signed-off-by: Brad Bodine <[email protected]> * Update inline_replacements.js Signed-off-by: Brad Bodine <[email protected]> --------- Signed-off-by: Brad Bodine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Current (incorrect) behavior:
User unable to Confirm removal of member.
New (correct) behavior:
User is able to remove household member clicking the 'Confirm' button in the remove member modal.
Pivotal Ticket Url
Ticket: https://www.pivotaltracker.com/story/show/188690910
PR Type
(Select 1)
PR Checklist
Please check if your PR fulfills the following requirements:
lethelpers andbeforeblocks..html_safe.Feature Flag
For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.
Variable name:
Additional Context
Include any additional context that may be relevant to the peer review process.