Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch with oregon branding #4926

Open
wants to merge 64 commits into
base: trunk
Choose a base branch
from
Open

branch with oregon branding #4926

wants to merge 64 commits into from

Conversation

kristinmerbach
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The title follows our guidelines
  • Tests for the changes have been added (for bug fixes/features), and they use let helpers and before blocks.
  • For all UI changes, there is Cucumber coverage.
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, the reasoning is documented in the PR and code.
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run them is documented in both the PR and the code.
  • There are no inline styles added.
  • There is no inline JavaScript added.
  • There is no hard-coded text added/updated in helpers/views/JavaScript. New/updated translation strings do not include markup/styles unless there is supporting documentation.
  • Code does not use .html_safe.
  • All images added/updated have alt text.
  • Does not bypass RuboCop rules in any way.

PR Type

What kind of change does this PR introduce?:

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix, Migration, or Report (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)

What is the ticket # detailing the issue?

Ticket:

A brief description of the changes:

Current behavior:

New behavior:

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

bbodine1
bbodine1 previously approved these changes Jan 13, 2025
*/
(function(){function z(a){return a&&a.domId&&a.getInputElement().$?a.getInputElement():a&&a.$?a:!1}function I(a){if(!a)throw"Languages-by-groups list are required for construct selectbox";var c=[],e="",d;for(d in a)for(var f in a[d]){var h=a[d][f];"en_US"==h?e=h:c.push(h)}c.sort();e&&c.unshift(e);return{getCurrentLangGroup:function(c){a:{for(var d in a)for(var e in a[d])if(e.toUpperCase()===c.toUpperCase()){c=d;break a}c=""}return c},setLangList:function(){var c={},d;for(d in a)for(var e in a[d])c[a[d][e]]=
e;return c}()}}var g=function(){var a=function(a,b,d){d=d||{};var f=d.expires;if("number"==typeof f&&f){var h=new Date;h.setTime(h.getTime()+1E3*f);f=d.expires=h}f&&f.toUTCString&&(d.expires=f.toUTCString());b=encodeURIComponent(b);a=a+"\x3d"+b;for(var k in d)b=d[k],a+="; "+k,!0!==b&&(a+="\x3d"+b);document.cookie=a};return{postMessage:{init:function(a){window.addEventListener?window.addEventListener("message",a,!1):window.attachEvent("onmessage",a)},send:function(a){var b=Object.prototype.toString,
d=a.fn||null,f=a.id||"",h=a.target||window,k=a.message||{id:f};a.message&&"[object Object]"==b.call(a.message)&&(a.message.id?a.message.id:a.message.id=f,k=a.message);a=window.JSON.stringify(k,d);h.postMessage(a,"*")},unbindHandler:function(a){window.removeEventListener?window.removeEventListener("message",a,!1):window.detachEvent("onmessage",a)}},hash:{create:function(){},parse:function(){}},cookie:{set:a,get:function(a){return(a=document.cookie.match(new RegExp("(?:^|; )"+a.replace(/([\.$?*|{}\(\)\[\]\\\/\+^])/g,

Check warning

Code scanning / CodeQL

Cross-window communication with unrestricted target origin Medium

Sensitive data
is sent to another window without origin restriction.
Sensitive data
is sent to another window without origin restriction.

Copilot Autofix AI 1 day ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

@kvootla kvootla requested a review from a team as a code owner January 15, 2025 16:32

validates :email, :email => true, :allow_blank => false

validates_format_of :email, :with => /\A[^@\s]+@([^@\s]+\.)+[^@\s]+\z/, message: "%{value} is not valid"

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with '!@' and containing many repetitions of '!.'.
before_action :set_cache_headers, only: [:show]
before_action :enable_bs4_layout, only: [:show, :messages, :inbox, :family_index] if EnrollRegistry.feature_enabled?(:bs4_assister_flow)

skip_before_action :verify_authenticity_token, only: :create

Check failure

Code scanning / CodeQL

CSRF protection weakened or disabled High

Potential CSRF vulnerability due to forgery protection being disabled or weakened.

Copilot Autofix AI 5 days ago

To fix the CSRF vulnerability, we need to ensure that CSRF protection is enabled for the create action. This can be done by removing the skip_before_action :verify_authenticity_token, only: :create line. This change will re-enable the default CSRF protection provided by Rails for the create action, ensuring that all requests to this action include a valid CSRF token.

Suggested changeset 1
components/benefit_sponsors/app/controllers/benefit_sponsors/profiles/assister_agencies/assister_agency_profiles_controller.rb

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/components/benefit_sponsors/app/controllers/benefit_sponsors/profiles/assister_agencies/assister_agency_profiles_controller.rb b/components/benefit_sponsors/app/controllers/benefit_sponsors/profiles/assister_agencies/assister_agency_profiles_controller.rb
--- a/components/benefit_sponsors/app/controllers/benefit_sponsors/profiles/assister_agencies/assister_agency_profiles_controller.rb
+++ b/components/benefit_sponsors/app/controllers/benefit_sponsors/profiles/assister_agencies/assister_agency_profiles_controller.rb
@@ -20,3 +20,2 @@
 
-        skip_before_action :verify_authenticity_token, only: :create
 
EOF
@@ -20,3 +20,2 @@

skip_before_action :verify_authenticity_token, only: :create

Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@alph_labels = @page_alphabets.map{|alph| [alph.first, alph.last].join("–")} if EnrollRegistry.feature_enabled?(:bs4_consumer_flow)
page_no = cur_page_no(@page_alphabets.first)
@staff = if @q.nil?
@staff.where(last_name: /^#{page_no}/i)

Check failure

Code scanning / CodeQL

Regular expression injection High

This regular expression depends on a
user-provided value
.
rahulgudim and others added 30 commits January 21, 2025 12:45
* add oregon seedfile

* change sep title
* add new oregon carrier to seedfile

* update carrier plan offer values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants