Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csp cucumber fixes 3 #4922

Merged
merged 15 commits into from
Jan 17, 2025
Merged

Conversation

RyanEddyIC
Copy link
Contributor

@RyanEddyIC RyanEddyIC commented Jan 13, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • The title follows our guidelines
  • Tests for the changes have been added (for bug fixes/features), and they use let helpers and before blocks.
  • For all UI changes, there is Cucumber coverage.
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, the reasoning is documented in the PR and code.
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run them is documented in both the PR and the code.
  • There are no inline styles added.
  • There is no inline JavaScript added.
  • There is no hard-coded text added/updated in helpers/views/JavaScript. New/updated translation strings do not include markup/styles unless there is supporting documentation.
  • Code does not use .html_safe.
  • All images added/updated have alt text.
  • Does not bypass RuboCop rules in any way.

PR Type

What kind of change does this PR introduce?:

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix, Migration, or Report (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)

What is the ticket # detailing the issue?

Ticket:
PT-188776875

A brief description of the changes:

Current behavior:

New behavior:

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

@RyanEddyIC RyanEddyIC force-pushed the csp-cucumber-fixes-2 branch from d74e87b to 1cd3e80 Compare January 13, 2025 17:03
@RyanEddyIC RyanEddyIC force-pushed the csp-cucumber-fixes-3 branch from ac4f73a to 602e100 Compare January 13, 2025 17:04
Base automatically changed from csp-cucumber-fixes-2 to epic_188588775_csp_enabled January 15, 2025 01:36
@RyanEddyIC RyanEddyIC force-pushed the csp-cucumber-fixes-3 branch from 4a5c746 to d2c3d2a Compare January 15, 2025 01:40
@bbodine1 bbodine1 force-pushed the epic_188588775_csp_enabled branch from d0d2c5e to 9c3a5ba Compare January 15, 2025 14:22
@RyanEddyIC RyanEddyIC force-pushed the csp-cucumber-fixes-3 branch from d2c3d2a to 46701ff Compare January 15, 2025 15:05
@bbodine1 bbodine1 force-pushed the epic_188588775_csp_enabled branch from 9c3a5ba to d7b3b66 Compare January 16, 2025 03:44
@RyanEddyIC RyanEddyIC force-pushed the csp-cucumber-fixes-3 branch 3 times, most recently from 171c649 to b3f9d0b Compare January 16, 2025 17:15
@bbodine1 bbodine1 force-pushed the epic_188588775_csp_enabled branch from e47d6cd to 7bc280b Compare January 16, 2025 18:43
@RyanEddyIC RyanEddyIC force-pushed the csp-cucumber-fixes-3 branch from b3f9d0b to 6ca6705 Compare January 16, 2025 19:34
@RyanEddyIC RyanEddyIC marked this pull request as ready for review January 16, 2025 20:18
@RyanEddyIC RyanEddyIC requested review from TreyE and bbodine1 January 16, 2025 20:18
@bbodine1 bbodine1 merged commit 6dd1676 into epic_188588775_csp_enabled Jan 17, 2025
128 checks passed
@bbodine1 bbodine1 deleted the csp-cucumber-fixes-3 branch January 17, 2025 13:46
bbodine1 pushed a commit that referenced this pull request Jan 18, 2025
* benefit application warning modal cucumber fix

* broker employers cucumber fixes

* fix disabled button check

* general agency staff cucumber fixes

* broker search cucumber fixes

* job income cucumber fixes

* ee waive cucumber fixes

* update disabled button css selector

* new plan year cucumber fixes

* plan year filter cucumber fixes

* fix admin paper cucumber step

* extend oe cucumber fixes

* rubocop fix

* actual rubocop fix

* update radio input checked selector
bbodine1 pushed a commit that referenced this pull request Jan 23, 2025
* benefit application warning modal cucumber fix

* broker employers cucumber fixes

* fix disabled button check

* general agency staff cucumber fixes

* broker search cucumber fixes

* job income cucumber fixes

* ee waive cucumber fixes

* update disabled button css selector

* new plan year cucumber fixes

* plan year filter cucumber fixes

* fix admin paper cucumber step

* extend oe cucumber fixes

* rubocop fix

* actual rubocop fix

* update radio input checked selector
bbodine1 pushed a commit that referenced this pull request Jan 24, 2025
* benefit application warning modal cucumber fix

* broker employers cucumber fixes

* fix disabled button check

* general agency staff cucumber fixes

* broker search cucumber fixes

* job income cucumber fixes

* ee waive cucumber fixes

* update disabled button css selector

* new plan year cucumber fixes

* plan year filter cucumber fixes

* fix admin paper cucumber step

* extend oe cucumber fixes

* rubocop fix

* actual rubocop fix

* update radio input checked selector
bbodine1 pushed a commit that referenced this pull request Jan 28, 2025
* benefit application warning modal cucumber fix

* broker employers cucumber fixes

* fix disabled button check

* general agency staff cucumber fixes

* broker search cucumber fixes

* job income cucumber fixes

* ee waive cucumber fixes

* update disabled button css selector

* new plan year cucumber fixes

* plan year filter cucumber fixes

* fix admin paper cucumber step

* extend oe cucumber fixes

* rubocop fix

* actual rubocop fix

* update radio input checked selector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants