-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update message deletion handling and improve close button functi… #4907
Merged
kristinmerbach
merged 1 commit into
epic_188588775_csp_enabled
from
188661185-benefit-sponsors-broker-agency-inbox
Jan 13, 2025
Merged
fix: update message deletion handling and improve close button functi… #4907
kristinmerbach
merged 1 commit into
epic_188588775_csp_enabled
from
188661185-benefit-sponsors-broker-agency-inbox
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbodine1
force-pushed
the
epic_188588775_csp_enabled
branch
from
January 8, 2025 02:37
d1028da
to
3f52b98
Compare
bbodine1
force-pushed
the
188661185-benefit-sponsors-broker-agency-inbox
branch
from
January 8, 2025 02:39
a3a1bf3
to
95900e5
Compare
RyanEddyIC
approved these changes
Jan 8, 2025
bbodine1
force-pushed
the
epic_188588775_csp_enabled
branch
from
January 9, 2025 03:24
da97272
to
6d04512
Compare
bbodine1
force-pushed
the
188661185-benefit-sponsors-broker-agency-inbox
branch
from
January 9, 2025 03:26
95900e5
to
691d132
Compare
bbodine1
force-pushed
the
epic_188588775_csp_enabled
branch
from
January 10, 2025 13:50
4267058
to
82ae86b
Compare
bbodine1
force-pushed
the
188661185-benefit-sponsors-broker-agency-inbox
branch
from
January 10, 2025 13:53
a86d3e6
to
400b5a3
Compare
bbodine1
force-pushed
the
epic_188588775_csp_enabled
branch
from
January 13, 2025 14:09
1039930
to
3856106
Compare
bbodine1
force-pushed
the
188661185-benefit-sponsors-broker-agency-inbox
branch
from
January 13, 2025 14:10
400b5a3
to
34a09b5
Compare
kristinmerbach
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kristinmerbach
merged commit Jan 13, 2025
e43ee0c
into
epic_188588775_csp_enabled
100 of 128 checks passed
kristinmerbach
deleted the
188661185-benefit-sponsors-broker-agency-inbox
branch
January 13, 2025 17:32
bbodine1
added a commit
that referenced
this pull request
Jan 15, 2025
#4907) fix: update message deletion handling and improve close button functionality
bbodine1
added a commit
that referenced
this pull request
Jan 16, 2025
#4907) fix: update message deletion handling and improve close button functionality
bbodine1
added a commit
that referenced
this pull request
Jan 16, 2025
#4907) fix: update message deletion handling and improve close button functionality
bbodine1
added a commit
that referenced
this pull request
Jan 18, 2025
#4907) fix: update message deletion handling and improve close button functionality
bbodine1
added a commit
that referenced
this pull request
Jan 23, 2025
#4907) fix: update message deletion handling and improve close button functionality
bbodine1
added a commit
that referenced
this pull request
Jan 24, 2025
#4907) fix: update message deletion handling and improve close button functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onality
PR Checklist
Please check if your PR fulfills the following requirements:
let
helpers andbefore
blocks..html_safe
.PR Type
What kind of change does this PR introduce?:
What is the ticket # detailing the issue?
Ticket: https://www.pivotaltracker.com/story/show/188661185
A brief description of the changes:
Current behavior:
Unable to use keyboard OR mouse to close deleted message banner.
New behavior:
Able to use keyboard OR mouse to close deleted message banner.
Feature Flag
For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.
Variable name:
Additional Context
Include any additional context that may be relevant to the peer review process.