Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update message deletion handling and improve close button functi… #4907

Conversation

bbodine1
Copy link
Contributor

@bbodine1 bbodine1 commented Jan 7, 2025

…onality

PR Checklist

Please check if your PR fulfills the following requirements:

  • The title follows our guidelines
  • Tests for the changes have been added (for bug fixes/features), and they use let helpers and before blocks.
  • For all UI changes, there is Cucumber coverage.
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, the reasoning is documented in the PR and code.
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run them is documented in both the PR and the code.
  • There are no inline styles added.
  • There is no inline JavaScript added.
  • There is no hard-coded text added/updated in helpers/views/JavaScript. New/updated translation strings do not include markup/styles unless there is supporting documentation.
  • Code does not use .html_safe.
  • All images added/updated have alt text.
  • Does not bypass RuboCop rules in any way.

PR Type

What kind of change does this PR introduce?:

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix, Migration, or Report (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)

What is the ticket # detailing the issue?

Ticket: https://www.pivotaltracker.com/story/show/188661185

A brief description of the changes:

Current behavior:
Unable to use keyboard OR mouse to close deleted message banner.

New behavior:
Able to use keyboard OR mouse to close deleted message banner.

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

@bbodine1 bbodine1 self-assigned this Jan 7, 2025
@bbodine1 bbodine1 force-pushed the epic_188588775_csp_enabled branch from d1028da to 3f52b98 Compare January 8, 2025 02:37
@bbodine1 bbodine1 requested a review from a team as a code owner January 8, 2025 02:37
@bbodine1 bbodine1 force-pushed the 188661185-benefit-sponsors-broker-agency-inbox branch from a3a1bf3 to 95900e5 Compare January 8, 2025 02:39
@bbodine1 bbodine1 force-pushed the epic_188588775_csp_enabled branch from da97272 to 6d04512 Compare January 9, 2025 03:24
@bbodine1 bbodine1 force-pushed the 188661185-benefit-sponsors-broker-agency-inbox branch from 95900e5 to 691d132 Compare January 9, 2025 03:26
@bbodine1 bbodine1 force-pushed the epic_188588775_csp_enabled branch from 4267058 to 82ae86b Compare January 10, 2025 13:50
@bbodine1 bbodine1 force-pushed the 188661185-benefit-sponsors-broker-agency-inbox branch from a86d3e6 to 400b5a3 Compare January 10, 2025 13:53
@bbodine1 bbodine1 force-pushed the epic_188588775_csp_enabled branch from 1039930 to 3856106 Compare January 13, 2025 14:09
@bbodine1 bbodine1 force-pushed the 188661185-benefit-sponsors-broker-agency-inbox branch from 400b5a3 to 34a09b5 Compare January 13, 2025 14:10
Copy link
Contributor

@kristinmerbach kristinmerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristinmerbach kristinmerbach merged commit e43ee0c into epic_188588775_csp_enabled Jan 13, 2025
100 of 128 checks passed
@kristinmerbach kristinmerbach deleted the 188661185-benefit-sponsors-broker-agency-inbox branch January 13, 2025 17:32
bbodine1 added a commit that referenced this pull request Jan 15, 2025
#4907)

fix: update message deletion handling and improve close button functionality
bbodine1 added a commit that referenced this pull request Jan 16, 2025
#4907)

fix: update message deletion handling and improve close button functionality
bbodine1 added a commit that referenced this pull request Jan 16, 2025
#4907)

fix: update message deletion handling and improve close button functionality
bbodine1 added a commit that referenced this pull request Jan 18, 2025
#4907)

fix: update message deletion handling and improve close button functionality
bbodine1 added a commit that referenced this pull request Jan 23, 2025
#4907)

fix: update message deletion handling and improve close button functionality
bbodine1 added a commit that referenced this pull request Jan 24, 2025
#4907)

fix: update message deletion handling and improve close button functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants