Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show submit button when broker agency is selected #4901

Conversation

bbodine1
Copy link
Contributor

@bbodine1 bbodine1 commented Jan 7, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • The title follows our guidelines
  • Tests for the changes have been added (for bug fixes/features), and they use let helpers and before blocks.
  • For all UI changes, there is Cucumber coverage.
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, the reasoning is documented in the PR and code.
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run them is documented in both the PR and the code.
  • There are no inline styles added.
  • There is no inline JavaScript added.
  • There is no hard-coded text added/updated in helpers/views/JavaScript. New/updated translation strings do not include markup/styles unless there is supporting documentation.
  • Code does not use .html_safe.
  • All images added/updated have alt text.
  • Does not bypass RuboCop rules in any way.

PR Type

What kind of change does this PR introduce?:

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix, Migration, or Report (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)

What is the ticket # detailing the issue?

Ticket: https://www.pivotaltracker.com/story/show/188747557

A brief description of the changes:

Current behavior:
Clicking on broker agency select button does not show the submit button

New behavior:
Clicking on broker agency select button shows the submit button

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

@bbodine1 bbodine1 self-assigned this Jan 7, 2025
@bbodine1 bbodine1 force-pushed the epic_188588775_csp_enabled branch from d1028da to 3f52b98 Compare January 8, 2025 02:37
@bbodine1 bbodine1 requested a review from a team as a code owner January 8, 2025 02:37
@bbodine1 bbodine1 force-pushed the 188747557-csp-enabled-unable-to-select-a-broker-agency-during-broker-staff-registration branch from 0a7ab0c to c6a16b6 Compare January 8, 2025 02:39
@bbodine1 bbodine1 merged commit ae88e44 into epic_188588775_csp_enabled Jan 8, 2025
100 of 128 checks passed
@bbodine1 bbodine1 deleted the 188747557-csp-enabled-unable-to-select-a-broker-agency-during-broker-staff-registration branch January 8, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants