Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

188739356 broker unable to delete office location via keyboard 2 #4898

Merged
merged 62 commits into from
Jan 7, 2025
Merged

188739356 broker unable to delete office location via keyboard 2 #4898

Changes from all commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
15a8765
Create main CSP branch.
TreyE Oct 2, 2024
bd8e7da
fix jquery with csp context
RyanEddyIC Dec 6, 2024
7b56e3b
rubocop fixes
RyanEddyIC Dec 6, 2024
dcbb29d
188588717 drop enrollment member (#4801)
RyanEddyIC Dec 11, 2024
e6b8a18
move inline js to external script (#4811)
RyanEddyIC Dec 11, 2024
e43690f
Update continue buttons on individual flow. (#4818)
TreyE Dec 12, 2024
1d92aad
remove inline js from family page add member forms (#4826)
RyanEddyIC Dec 12, 2024
1d0f3b4
Keyboard navigation functions updates (#4832)
bbodine1 Dec 16, 2024
f528290
rubocop fix
RyanEddyIC Dec 16, 2024
c0b41fd
188658143 plan shopping compare plan (#4835)
anncaballeroo Dec 16, 2024
0f1c072
Refactor checkbox selection and clean up unused code in product index…
bbodine1 Dec 16, 2024
e79539d
sep admin detail onclick refactor (#4836)
charlienparker Dec 17, 2024
194b006
build the image for the csp branch (#4846)
kristinmerbach Dec 17, 2024
87bd8ad
self employed keydown removal (#4839)
charlienparker Dec 17, 2024
4aabd34
removal of in line event in the help me sign up button (#4845)
anncaballeroo Dec 17, 2024
5be8aca
fix primary nav layout when bs4 disabled (#4840)
RyanEddyIC Dec 17, 2024
aa3b218
Refactor upload button attributes for improved accessibility and cons…
bbodine1 Dec 18, 2024
620cfbe
removal of in line event (#4842)
anncaballeroo Dec 18, 2024
d3cef30
removal of in line event in the broker add office location button (#4…
anncaballeroo Dec 18, 2024
b7dba4f
add event initializers to edit.js.erb (#4843)
RyanEddyIC Dec 18, 2024
9ea246f
removal of inline events (#4837)
anncaballeroo Dec 18, 2024
6eb64e1
remove safe selectors not supported
bbodine1 Dec 18, 2024
f80ed35
move inline js to external file (#4810)
RyanEddyIC Dec 19, 2024
200cd29
remoavl of in line event (#4847)
anncaballeroo Dec 19, 2024
d86a438
refactor confirm button to use data attribute for keydown event handl…
bbodine1 Dec 19, 2024
2ced60c
sep date inline fix (#4858)
charlienparker Dec 20, 2024
c9ce876
job income inline fixes (#4848)
charlienparker Dec 20, 2024
bea4e98
removal of in line events (#4870)
anncaballeroo Dec 20, 2024
54a51ff
removal of in line events (#4869)
anncaballeroo Dec 20, 2024
3cb261f
other income ai an inline fixes (#4851)
charlienparker Dec 20, 2024
276d86b
removal of in line JS (#4863)
anncaballeroo Dec 20, 2024
e2a6095
fix keyboard navigation double firing function and keyboard upload on…
bbodine1 Dec 23, 2024
dfd673b
unemployment income inline fixes (#4849)
charlienparker Dec 23, 2024
7baf46c
other income inline fixes (#4850)
charlienparker Dec 23, 2024
fce9018
deductions inline fixes (#4853)
charlienparker Dec 23, 2024
69ca7ab
remove of onclick events (#4862)
anncaballeroo Dec 23, 2024
af0985b
sep moving fields onkeydown refactor (#4864)
charlienparker Dec 23, 2024
fb571c9
removal of in line JS (#4876)
anncaballeroo Dec 23, 2024
f17b629
Update keyboard_navigation.js
bbodine1 Dec 24, 2024
b8d98d0
sep effective on kinds fields inline fix (#4872)
charlienparker Dec 24, 2024
09c4361
temporary fix for broken faa cucumber steps (#4854)
RyanEddyIC Dec 24, 2024
3f988a7
benefits inline fixes (#4852)
charlienparker Dec 24, 2024
bddbbc9
fix: correct modal IDs and form IDs for termination date updates (#4867)
bbodine1 Dec 30, 2024
1eea218
188690910 faa applicant demographics (#4856)
bbodine1 Dec 30, 2024
cec7021
188655868 sep insurance fields inline fix (#4871)
charlienparker Dec 30, 2024
1c4c6e5
sep marriage fields inline fix (#4868)
charlienparker Dec 30, 2024
4658217
Refactor personal form JavaScript: move inline script to separate fil…
bbodine1 Dec 31, 2024
5127983
other questions footer clipping (#4882)
charlienparker Dec 31, 2024
5e2fef3
188660630 csp enabled create broker agency button disabled (#4857)
bbodine1 Jan 2, 2025
b99042a
fix inline js broken on edit view (#4884)
bbodine1 Jan 2, 2025
fdc3f6b
fix: ensure customPlugin is registered only once for live chat error …
bbodine1 Jan 2, 2025
3ee3927
fix brakeman warnings (#4888)
RyanEddyIC Jan 3, 2025
865d69b
fix: broker agency search functionality broken (#4886)
bbodine1 Jan 3, 2025
716b703
fix: add data-keydown-id attribute to remove location button for acce…
bbodine1 Jan 6, 2025
334299c
fix: cleave js error and move js to correct file (#4891)
bbodine1 Jan 6, 2025
c09f155
fix: keydown not working and multiple click equals multiple submissio…
bbodine1 Jan 6, 2025
be08ad3
fix: add data-keydown-id attribute to remove location button for acce…
bbodine1 Jan 6, 2025
014d10e
fix: broken broker inbox (#4892)
bbodine1 Jan 6, 2025
962214c
move turbolinks nonce header js out of application.js (#4894)
RyanEddyIC Jan 6, 2025
d26439e
fix: update remove location button to use data-keydown-id for improve…
bbodine1 Jan 6, 2025
33821da
Merge branch 'epic_188588775_csp_enabled' into 188739356-broker-unabl…
bbodine1 Jan 7, 2025
dd48876
Merge branch 'epic_188588775_csp_enabled' into 188739356-broker-unabl…
bbodine1 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/javascript/benefit_sponsors/controllers/office_locations_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export default class extends Controller {
removeButton.classList.remove('hidden');
var removeButtonId = "remove-button-" + totalLocationsCount;
removeButton.id = removeButtonId;
removeButton.setAttribute('onkeydown', `handleButtonKeyDown(event, '${removeButtonId}')`);
removeButton.setAttribute('data-keydown-id', `${removeButtonId}`);
newLocation.querySelector('input[placeholder="00000"]').setAttribute('data-action', "");

// need to explicitly add event listeners for onInput and onInvalid for phone number fields:
Expand Down
Loading