-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move turbolinks nonce header js out of application.js #4894
Merged
TreyE
merged 2 commits into
epic_188588775_csp_enabled
from
turbolinks-nonce-initializer
Jan 6, 2025
Merged
move turbolinks nonce header js out of application.js #4894
TreyE
merged 2 commits into
epic_188588775_csp_enabled
from
turbolinks-nonce-initializer
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanEddyIC
force-pushed
the
turbolinks-nonce-initializer
branch
from
January 6, 2025 16:52
85182ec
to
ca5a469
Compare
bbodine1
approved these changes
Jan 6, 2025
TreyE
approved these changes
Jan 6, 2025
bbodine1
pushed a commit
that referenced
this pull request
Jan 7, 2025
* move turbolinks nonce header js out of application.js * remove temporary cucumber fix steps
bbodine1
pushed a commit
that referenced
this pull request
Jan 8, 2025
* move turbolinks nonce header js out of application.js * remove temporary cucumber fix steps
bbodine1
pushed a commit
that referenced
this pull request
Jan 9, 2025
* move turbolinks nonce header js out of application.js * remove temporary cucumber fix steps
bbodine1
pushed a commit
that referenced
this pull request
Jan 10, 2025
* move turbolinks nonce header js out of application.js * remove temporary cucumber fix steps
bbodine1
pushed a commit
that referenced
this pull request
Jan 13, 2025
* move turbolinks nonce header js out of application.js * remove temporary cucumber fix steps
bbodine1
pushed a commit
that referenced
this pull request
Jan 15, 2025
* move turbolinks nonce header js out of application.js * remove temporary cucumber fix steps
bbodine1
pushed a commit
that referenced
this pull request
Jan 16, 2025
* move turbolinks nonce header js out of application.js * remove temporary cucumber fix steps
bbodine1
pushed a commit
that referenced
this pull request
Jan 16, 2025
* move turbolinks nonce header js out of application.js * remove temporary cucumber fix steps
bbodine1
pushed a commit
that referenced
this pull request
Jan 18, 2025
* move turbolinks nonce header js out of application.js * remove temporary cucumber fix steps
bbodine1
pushed a commit
that referenced
this pull request
Jan 23, 2025
* move turbolinks nonce header js out of application.js * remove temporary cucumber fix steps
bbodine1
pushed a commit
that referenced
this pull request
Jan 24, 2025
* move turbolinks nonce header js out of application.js * remove temporary cucumber fix steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
let
helpers andbefore
blocks..html_safe
.PR Type
What kind of change does this PR introduce?:
What is the ticket # detailing the issue?
Ticket:
A brief description of the changes:
Current behavior:
The current initializer for the turbolinks nonce header was not loading or working as expected
New behavior:
Turbolinks nonce header will be properly included throughout the app
Feature Flag
For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.
Variable name:
Additional Context
Include any additional context that may be relevant to the peer review process.