Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temporary fix for broken faa cucumber steps #4854

Merged
merged 11 commits into from
Dec 24, 2024
Merged

temporary fix for broken faa cucumber steps #4854

merged 11 commits into from
Dec 24, 2024

Conversation

RyanEddyIC
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The title follows our guidelines
  • Tests for the changes have been added (for bug fixes/features), and they use let helpers and before blocks.
  • For all UI changes, there is Cucumber coverage.
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, the reasoning is documented in the PR and code.
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run them is documented in both the PR and the code.
  • There are no inline styles added.
  • There is no inline JavaScript added.
  • There is no hard-coded text added/updated in helpers/views/JavaScript. New/updated translation strings do not include markup/styles unless there is supporting documentation.
  • Code does not use .html_safe.
  • All images added/updated have alt text.
  • Does not bypass RuboCop rules in any way.

PR Type

What kind of change does this PR introduce?:

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix, Migration, or Report (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)

What is the ticket # detailing the issue?

Ticket:

A brief description of the changes:

Current behavior:

New behavior:

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

@bbodine1 bbodine1 force-pushed the epic_188588775_csp_enabled branch from a856f7d to 95095b0 Compare December 19, 2024 14:26
@RyanEddyIC RyanEddyIC force-pushed the csp_faa_inline_js branch 2 times, most recently from 755d6a3 to b5ccc45 Compare December 20, 2024 21:06
@bbodine1 bbodine1 force-pushed the epic_188588775_csp_enabled branch from 820c9db to 3626348 Compare December 21, 2024 17:54
@RyanEddyIC RyanEddyIC force-pushed the csp_faa_inline_js branch 2 times, most recently from bcc3d75 to 8fb2eeb Compare December 23, 2024 19:37
@RyanEddyIC RyanEddyIC marked this pull request as ready for review December 23, 2024 20:00
bbodine1
bbodine1 reviewed Dec 23, 2024
View reviewed changes
components/financial_assistance/app/views/financial_assistance/applicants/tax_info.html.erb Outdated Show resolved Hide resolved
...onents/financial_assistance/app/views/financial_assistance/applications/preferences.html.erb Outdated Show resolved Hide resolved
...cial_assistance/app/views/financial_assistance/applications/submit_your_application.html.erb Outdated Show resolved Hide resolved
components/financial_assistance/app/views/financial_assistance/benefits/index.html.erb Outdated Show resolved Hide resolved
components/financial_assistance/app/views/financial_assistance/deductions/index.html.erb Outdated Show resolved Hide resolved
components/financial_assistance/app/views/financial_assistance/incomes/index.html.erb Outdated Show resolved Hide resolved
components/financial_assistance/app/views/financial_assistance/incomes/other.html.erb Outdated Show resolved Hide resolved
components/ui_helpers/app/views/workflow/step.html.erb Outdated Show resolved Hide resolved
@bbodine1 bbodine1 force-pushed the epic_188588775_csp_enabled branch from a6e2c15 to d5a5c35 Compare December 24, 2024 05:02
@bbodine1 bbodine1 requested a review from a team as a code owner December 24, 2024 05:02
@bbodine1 bbodine1 merged commit d120dc4 into epic_188588775_csp_enabled Dec 24, 2024
3 of 4 checks passed
@bbodine1 bbodine1 deleted the csp_faa_inline_js branch December 24, 2024 18:03
bbodine1 added a commit that referenced this pull request Dec 25, 2024
@RyanEddyIC @bbodine1
temporary fix for broken faa cucumber steps (#4854)
2984a95 
* temporary fix for broken faa cucumber steps

* fix income forms

* add bs4 to date validation

* fix back to household buttons

* fix deduction form ids

* tax info cucumber fix

* cucumber step fixes

* add driver alert accept to step

* remove javascript void from anchors

---------

Co-authored-by: Brad Bodine <[email protected]>
bbodine1 added a commit that referenced this pull request Dec 31, 2024
@RyanEddyIC @bbodine1
temporary fix for broken faa cucumber steps (#4854)
ec84caf 
* temporary fix for broken faa cucumber steps

* fix income forms

* add bs4 to date validation

* fix back to household buttons

* fix deduction form ids

* tax info cucumber fix

* cucumber step fixes

* add driver alert accept to step

* remove javascript void from anchors

---------

Co-authored-by: Brad Bodine <[email protected]>
bbodine1 added a commit that referenced this pull request Jan 5, 2025
@RyanEddyIC @bbodine1
temporary fix for broken faa cucumber steps (#4854)
09c4361 
* temporary fix for broken faa cucumber steps

* fix income forms

* add bs4 to date validation

* fix back to household buttons

* fix deduction form ids

* tax info cucumber fix

* cucumber step fixes

* add driver alert accept to step

* remove javascript void from anchors

---------

Co-authored-by: Brad Bodine <[email protected]>
bbodine1 added a commit that referenced this pull request Jan 7, 2025
@RyanEddyIC @bbodine1
temporary fix for broken faa cucumber steps (#4854)
30acafe 
* temporary fix for broken faa cucumber steps

* fix income forms

* add bs4 to date validation

* fix back to household buttons

* fix deduction form ids

* tax info cucumber fix

* cucumber step fixes

* add driver alert accept to step

* remove javascript void from anchors

---------

Co-authored-by: Brad Bodine <[email protected]>
bbodine1 added a commit that referenced this pull request Jan 8, 2025
@RyanEddyIC @bbodine1
temporary fix for broken faa cucumber steps (#4854)
c99ad68 
* temporary fix for broken faa cucumber steps

* fix income forms

* add bs4 to date validation

* fix back to household buttons

* fix deduction form ids

* tax info cucumber fix

* cucumber step fixes

* add driver alert accept to step

* remove javascript void from anchors

---------

Co-authored-by: Brad Bodine <[email protected]>
bbodine1 added a commit that referenced this pull request Jan 9, 2025
@RyanEddyIC @bbodine1
temporary fix for broken faa cucumber steps (#4854)
933594b 
* temporary fix for broken faa cucumber steps

* fix income forms

* add bs4 to date validation

* fix back to household buttons

* fix deduction form ids

* tax info cucumber fix

* cucumber step fixes

* add driver alert accept to step

* remove javascript void from anchors

---------

Co-authored-by: Brad Bodine <[email protected]>
bbodine1 added a commit that referenced this pull request Jan 10, 2025
@RyanEddyIC @bbodine1
temporary fix for broken faa cucumber steps (#4854)
82e6800 
* temporary fix for broken faa cucumber steps

* fix income forms

* add bs4 to date validation

* fix back to household buttons

* fix deduction form ids

* tax info cucumber fix

* cucumber step fixes

* add driver alert accept to step

* remove javascript void from anchors

---------

Co-authored-by: Brad Bodine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anncaballeroo anncaballeroo anncaballeroo approved these changes

@bbodine1 bbodine1 bbodine1 approved these changes

@charlienparker charlienparker Awaiting requested review from charlienparker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanEddyIC @bbodine1 @anncaballeroo