verification details household summary #4788
Draft
+675
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect, add can_display_check added by TT6, refactor verification_documents_controller to support new flash and redirect, add action table pattern, refactor file_upload_validator to allow human readable pluralized and sentenced types,
charlienparker
changed the base branch from
trunk
to
verifications-household-summary
charlienparker
commented
Dec 2, 2024
There was a problem hiding this comment.
cleaning up some unrelated tech debt to the other BS4 breadcrumbs in the app
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ady listeners to ensure reloads don't break action nav
charlienparker
commented
Dec 2, 2024
| } | ||
|
|
||
| // Repesents a file attached to the form | ||
| AttachFileElement = class { |
There was a problem hiding this comment.
I'm open to introducing a partial for this instead, so when we need to render these attachment rows after the user uses the input, we can just render the partial instead of constructing the element in JS as we are here.
The con is that it's going to be a super short partial only ever used here...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
lethelpers andbeforeblocks..html_safe.PR Type
What kind of change does this PR introduce?:
What is the ticket # detailing the issue?
Ticket:
A brief description of the changes:
Current behavior:
New behavior:
Feature Flag
For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.
Variable name:
Additional Context
Include any additional context that may be relevant to the peer review process.