Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update actions to version v4 and add single cuke runner #4517

Open
wants to merge 37 commits into
base: trunk
Choose a base branch
from

Conversation

brianhenryhf
Copy link

@brianhenryhf brianhenryhf commented Sep 16, 2024

PR Checklist

Please check if your PR fulfills the following requirements

  • The title follows our guidelines
  • Tests for the changes have been added (for bugfixes/features), they use let helpers and before blocks
  • For all UI changes, there is cucumber coverage
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, reasoning is documented in PR and code
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run it is documented on both the PR and in the code
  • There are no inline styles added
  • There are no inline javascript added
  • There is no hard coded text added/updated in helpers/views/Javascript. New/updated translation strings do not include markup/styles, unless there is supporting documentation
  • Code does not use .html_safe
  • All images added/updated have alt text
  • Doesn’t bypass rubocop rules in any way

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix or migration (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)

What is the ticket # detailing the issue?

Ticket: https://www.pivotaltracker.com/n/projects/2640062/stories/188666750

A brief description of the changes

Current behavior: All cucumbers must run, and devs have to wait and find a problem feature after pushing attempted changes.

New behavior: A GHA workflow is added that can be run on-demand, to launch a specific cucumber feature.

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

Additional GHA updates:

  • Updates all older GH cache|checkout|setup-node actions to v4 (removes noisy node deprecation messages).
  • Updates all GH container environment node versions to 14, for consistency.
  • Updates up/download-artifact actions to v4 (imminent deprecation of <v4, better performance, show artifact urls in logs, faster access to artifacts in workflow runs).
  • Remove unneeded dependency, update report generator action (previous state for each used deprecated node versions).
  • Adjust Rubocop check to show issues encountered in GHA logs.
  • Rubocop fix to avoid incorrect branch comparisons (when longer-lived feature/epic branches are in play).

Note: this fixes most, but not all, deprecations/warnings in workflow runs - build/tag-related workflows are very conservatively updated (only cache|checkout actions bumped).

… trunk

for pr's based on non-trunk, this avoids mysterious failures that have nothing to do with code changed in pr
- for performance, keeping up-to-date, faster availability
- v4 requires names to be unique
- some names also referenced matrix dimensions that didn't exist
@polographer polographer changed the title add single cuke runner update actions to version v4 and add single cuke runner Dec 11, 2024
@polographer polographer marked this pull request as ready for review December 11, 2024 22:38
@polographer polographer requested a review from a team as a code owner December 11, 2024 22:38
@saikumar9 saikumar9 requested a review from TreyE December 12, 2024 15:30
Copy link
Member

@saikumar9 saikumar9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@saikumar9 saikumar9 enabled auto-merge (squash) December 12, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants