-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update actions to version v4 and add single cuke runner #4517
Open
brianhenryhf
wants to merge
37
commits into
trunk
Choose a base branch
from
add_single_cuke_runner
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… trunk for pr's based on non-trunk, this avoids mysterious failures that have nothing to do with code changed in pr
brianhenryhf
force-pushed
the
add_single_cuke_runner
branch
from
September 16, 2024 22:09
a47b483
to
9b51327
Compare
in a reasonable amt of time
brianhenryhf
force-pushed
the
add_single_cuke_runner
branch
from
September 16, 2024 22:23
f74d69f
to
02dcbbb
Compare
brianhenryhf
force-pushed
the
add_single_cuke_runner
branch
from
September 26, 2024 22:45
8762a68
to
7fc1aec
Compare
brianhenryhf
force-pushed
the
add_single_cuke_runner
branch
from
September 26, 2024 22:53
7fc1aec
to
67e5395
Compare
fxnality provided is native to GHA currently
brianhenryhf
force-pushed
the
add_single_cuke_runner
branch
from
September 30, 2024 20:38
bc20e17
to
0ab24a3
Compare
brianhenryhf
force-pushed
the
add_single_cuke_runner
branch
from
September 30, 2024 22:07
d3a3da9
to
af1a076
Compare
- for performance, keeping up-to-date, faster availability - v4 requires names to be unique - some names also referenced matrix dimensions that didn't exist
brianhenryhf
force-pushed
the
add_single_cuke_runner
branch
from
September 30, 2024 22:41
af1a076
to
9f864f7
Compare
This reverts commit 9f864f7.
polographer
changed the title
add single cuke runner
update actions to version v4 and add single cuke runner
Dec 11, 2024
saikumar9
reviewed
Dec 12, 2024
saikumar9
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements
PR Type
What kind of change does this PR introduce?
What is the ticket # detailing the issue?
Ticket: https://www.pivotaltracker.com/n/projects/2640062/stories/188666750
A brief description of the changes
Current behavior: All cucumbers must run, and devs have to wait and find a problem feature after pushing attempted changes.
New behavior: A GHA workflow is added that can be run on-demand, to launch a specific cucumber feature.
Feature Flag
For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and which client(s) it applies to.
Variable name:
Additional Context
Include any additional context that may be relevant to the peer review process.
Additional GHA updates:
cache|checkout|setup-node
actions to v4 (removes noisy node deprecation messages).up/download-artifact
actions to v4 (imminent deprecation of <v4, better performance, show artifact urls in logs, faster access to artifacts in workflow runs).Note: this fixes most, but not all, deprecations/warnings in workflow runs - build/tag-related workflows are very conservatively updated (only
cache|checkout
actions bumped).