Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding determination reasons in cv3 payload #4093

Merged
merged 11 commits into from
Aug 13, 2024

Conversation

nisanthyaganti9
Copy link
Contributor

@nisanthyaganti9 nisanthyaganti9 commented Jul 26, 2024

PR Checklist

Please check if your PR fulfills the following requirements

  • The title follows our guidelines
  • Tests for the changes have been added (for bugfixes/features), they use let helpers and before blocks
  • For all UI changes, there is cucumber coverage
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, reasoning is documented in PR and code
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run it is documented on both the PR and in the code
  • There are no inline styles added
  • There are no inline javascript added
  • There is no hard coded text added/updated in helpers/views/Javascript. New/updated translation strings do not include markup/styles, unless there is supporting documentation
  • Code does not use .html_safe
  • All images added/updated have alt text
  • Doesn’t bypass rubocop rules in any way

PR Type

What kind of change does this PR introduce?
Adding determination reasons to cv3 payload

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix or migration (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)

What is the ticket # detailing the issue?

Ticket: https://www.pivotaltracker.com/story/show/187862378

A brief description of the changes

Current behavior:

New behavior: Adding determination reasons to cv3 payload

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

AppScan CodeSweep Failure

In the event of a failed check on the AppScan CodeSweep step of our GitHub Actions workflow, please review the False Positive protocol outlined here: appscan_codesweep/CODESWEEP_FALSE_POSITIVES_README.MD

Add all required notes to this section if the failure is a suspected false positive.

@nisanthyaganti9 nisanthyaganti9 changed the title adding determination resons in cv3 payload adding determination reasons in cv3 payload Jul 26, 2024
@nisanthyaganti9 nisanthyaganti9 requested a review from a team as a code owner July 26, 2024 16:56
saipraveen18
saipraveen18 previously approved these changes Jul 30, 2024
@TreyE TreyE force-pushed the 187862378-add-determination-reason branch from 2b08583 to 3941656 Compare August 2, 2024 15:36
@TreyE TreyE force-pushed the 187862378-add-determination-reason branch from bbef9c2 to d780c65 Compare August 12, 2024 12:19
@TreyE TreyE force-pushed the 187862378-add-determination-reason branch from d780c65 to 64dd267 Compare August 12, 2024 12:42
saikumar9
saikumar9 previously approved these changes Aug 12, 2024
Copy link
Member

@saikumar9 saikumar9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@saikumar9 saikumar9 enabled auto-merge (squash) August 12, 2024 16:41
@saikumar9 saikumar9 requested a review from saipraveen18 August 12, 2024 16:41
saipraveen18
saipraveen18 previously approved these changes Aug 12, 2024
@saipraveen18 saipraveen18 dismissed stale reviews from saikumar9 and themself via b3eb348 August 12, 2024 18:27
saikumar9
saikumar9 previously approved these changes Aug 12, 2024
saipraveen18
saipraveen18 previously approved these changes Aug 12, 2024
@saikumar9 saikumar9 dismissed stale reviews from saipraveen18 and themself via 5aa8bbe August 12, 2024 21:05
@saikumar9 saikumar9 merged commit 46ae5e2 into trunk Aug 13, 2024
119 checks passed
@saikumar9 saikumar9 deleted the 187862378-add-determination-reason branch August 13, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants