Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan shopping review and submit #4026

Merged

Conversation

kristinmerbach
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements

  • The title follows our guidelines
  • Tests for the changes have been added (for bugfixes/features), they use let helpers and before blocks
  • For all UI changes, there is cucumber coverage
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, reasoning is documented in PR and code
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run it is documented on both the PR and in the code
  • There are no inline styles added
  • There are no inline javascript added
  • There is no hard coded text added/updated in helpers/views/Javascript. New/updated translation strings do not include markup/styles, unless there is supporting documentation
  • Code does not use .html_safe
  • All images added/updated have alt text
  • Doesn’t bypass rubocop rules in any way

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix or migration (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)

What is the ticket # detailing the issue?

Ticket:

A brief description of the changes

Current behavior:

New behavior:

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

AppScan CodeSweep Failure

In the event of a failed check on the AppScan CodeSweep step of our GitHub Actions workflow, please review the False Positive protocol outlined here: appscan_codesweep/CODESWEEP_FALSE_POSITIVES_README.MD

Add all required notes to this section if the failure is a suspected false positive.

@kristinmerbach kristinmerbach marked this pull request as draft July 15, 2024 18:03
@kristinmerbach kristinmerbach marked this pull request as ready for review July 15, 2024 22:54
@kristinmerbach kristinmerbach marked this pull request as draft July 15, 2024 23:19
@ATBull81 ATBull81 force-pushed the clean-bootstrap-4-upgrade branch from 36a22ff to 5a7b9c4 Compare July 19, 2024 13:07
@kristinmerbach kristinmerbach force-pushed the plan_shopping_review_and_submit branch from 05f85d1 to 59b7b9a Compare July 20, 2024 19:21
@kristinmerbach kristinmerbach marked this pull request as ready for review July 20, 2024 22:40
@kristinmerbach kristinmerbach merged commit a7e548c into clean-bootstrap-4-upgrade Jul 20, 2024
7 of 8 checks passed
@kristinmerbach kristinmerbach deleted the plan_shopping_review_and_submit branch July 20, 2024 22:42
bbodine1 pushed a commit that referenced this pull request Jul 22, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Jul 26, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Jul 30, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Jul 31, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 1, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 2, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 3, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 6, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 7, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 9, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 10, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 13, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 14, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 15, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 16, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 19, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 20, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 20, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 22, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 23, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 27, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 28, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
bbodine1 pushed a commit that referenced this pull request Aug 29, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
kristinmerbach added a commit that referenced this pull request Sep 4, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
kristinmerbach added a commit that referenced this pull request Sep 6, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
kristinmerbach added a commit that referenced this pull request Sep 10, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
charlienparker pushed a commit that referenced this pull request Sep 13, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
charlienparker pushed a commit that referenced this pull request Sep 16, 2024
* more work on consumer flow

* upgrade to bs4 base

* revert temp changes for design review to trunk

* personal information page redo

* plan shopping page visuals work

* more plan shopping styling

* minor fixes

* clean up from rebase

* receipt page translations

* upgrade to bs4 base

* revert temp changes for design review to trunk

* fix fonts, more ridp work started

* plan shopping page visuals work

* started review submitted plan page

* started calculator plus lots of cleanup

* session timeout

* faa manage family fixes

* fdsh error

* no flash on waiting for elgi results

* plan shopping tile

* aptc minumum

---------

Signed-off-by: kristinmerbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants