-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
responds only to valid MIME types for users controller #3743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymhari
approved these changes
Apr 16, 2024
TristanB17
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jacobkagon
pushed a commit
that referenced
this pull request
Apr 29, 2024
* responds only to valid MIME types for users controller * adds YARD documentation
jacobkagon
pushed a commit
that referenced
this pull request
May 6, 2024
* responds only to valid MIME types for users controller * adds YARD documentation
jacobkagon
pushed a commit
that referenced
this pull request
May 15, 2024
* responds only to valid MIME types for users controller * adds YARD documentation
jacobkagon
pushed a commit
that referenced
this pull request
May 29, 2024
* responds only to valid MIME types for users controller * adds YARD documentation
jacobkagon
pushed a commit
that referenced
this pull request
May 29, 2024
* responds only to valid MIME types for users controller * adds YARD documentation
jacobkagon
pushed a commit
that referenced
this pull request
May 29, 2024
* responds only to valid MIME types for users controller * adds YARD documentation
jacobkagon
pushed a commit
that referenced
this pull request
Jun 12, 2024
* responds only to valid MIME types for users controller * adds YARD documentation
jacobkagon
pushed a commit
that referenced
this pull request
Jun 12, 2024
* responds only to valid MIME types for users controller * adds YARD documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements
PR Type
What kind of change does this PR introduce?
What is the ticket # detailing the issue?
Ticket: IVL Product Development - 187415754
A brief description of the changes
Current behavior: Some endpoints of UserController respond to unsupported MIME types.
New behavior: All the endpoints of UserController will only respond to supported MIME types.
Feature Flag
For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and which client(s) it applies to.
Variable name:
Additional Context
Include any additional context that may be relevant to the peer review process.
AppScan CodeSweep Failure
In the event of a failed check on the AppScan CodeSweep step of our GitHub Actions workflow, please review the False Positive protocol outlined here: appscan_codesweep/CODESWEEP_FALSE_POSITIVES_README.MD
Add all required notes to this section if the failure is a suspected false positive.