Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

responds only to valid MIME types for users controller #3743

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

saikumar9
Copy link
Member

@saikumar9 saikumar9 commented Apr 15, 2024

PR Checklist

Please check if your PR fulfills the following requirements

  • The title follows our guidelines
  • Tests for the changes have been added (for bugfixes/features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix or migration (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)

What is the ticket # detailing the issue?

Ticket: IVL Product Development - 187415754

A brief description of the changes

Current behavior: Some endpoints of UserController respond to unsupported MIME types.

New behavior: All the endpoints of UserController will only respond to supported MIME types.

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

AppScan CodeSweep Failure

In the event of a failed check on the AppScan CodeSweep step of our GitHub Actions workflow, please review the False Positive protocol outlined here: appscan_codesweep/CODESWEEP_FALSE_POSITIVES_README.MD

Add all required notes to this section if the failure is a suspected false positive.

@saikumar9 saikumar9 marked this pull request as draft April 15, 2024 22:23
@saikumar9 saikumar9 marked this pull request as ready for review April 15, 2024 23:39
@saikumar9 saikumar9 requested review from TreyE and saipraveen18 April 15, 2024 23:40
@saikumar9 saikumar9 enabled auto-merge (squash) April 15, 2024 23:40
@TristanB17 TristanB17 self-requested a review April 16, 2024 15:22
Copy link
Contributor

@TristanB17 TristanB17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikumar9 saikumar9 merged commit 54bf4fb into trunk Apr 16, 2024
115 checks passed
@saikumar9 saikumar9 deleted the pt_187415754 branch April 16, 2024 15:23
jacobkagon pushed a commit that referenced this pull request Apr 29, 2024
* responds only to valid MIME types for users controller

* adds YARD documentation
jacobkagon pushed a commit that referenced this pull request May 6, 2024
* responds only to valid MIME types for users controller

* adds YARD documentation
jacobkagon pushed a commit that referenced this pull request May 15, 2024
* responds only to valid MIME types for users controller

* adds YARD documentation
jacobkagon pushed a commit that referenced this pull request May 29, 2024
* responds only to valid MIME types for users controller

* adds YARD documentation
jacobkagon pushed a commit that referenced this pull request May 29, 2024
* responds only to valid MIME types for users controller

* adds YARD documentation
jacobkagon pushed a commit that referenced this pull request May 29, 2024
* responds only to valid MIME types for users controller

* adds YARD documentation
jacobkagon pushed a commit that referenced this pull request Jun 12, 2024
* responds only to valid MIME types for users controller

* adds YARD documentation
jacobkagon pushed a commit that referenced this pull request Jun 12, 2024
* responds only to valid MIME types for users controller

* adds YARD documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants