adds ssn to the sensitive parameters list #3733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikumar9
requested review from
TreyE and
saipraveen18
and removed request for
TreyE and
saipraveen18
…ed with [FILTERED] in the logs
TreyE
approved these changes
Apr 12, 2024
saipraveen18
approved these changes
Apr 12, 2024
saipraveen18
pushed a commit
that referenced
this pull request
Apr 15, 2024
adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs
saikumar9
added a commit
that referenced
this pull request
Apr 17, 2024
* add rel attributes to external links * adds ssn to the sensitive parameters list (#3733) adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs * fix app scan issues * fix one last app scan issue * use h helper instead of sanitize_html * add spec * add a few missing rel noopener noreferrer attrs to links * add escape to html links * remove redundant rel attr from link --------- Co-authored-by: Sai Kumar Kotagiri <[email protected]> Co-authored-by: TristanB17 <[email protected]>
jacobkagon
pushed a commit
that referenced
this pull request
Apr 29, 2024
adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs
jacobkagon
pushed a commit
that referenced
this pull request
Apr 29, 2024
* add rel attributes to external links * adds ssn to the sensitive parameters list (#3733) adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs * fix app scan issues * fix one last app scan issue * use h helper instead of sanitize_html * add spec * add a few missing rel noopener noreferrer attrs to links * add escape to html links * remove redundant rel attr from link --------- Co-authored-by: Sai Kumar Kotagiri <[email protected]> Co-authored-by: TristanB17 <[email protected]>
jacobkagon
pushed a commit
that referenced
this pull request
May 6, 2024
adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs
jacobkagon
pushed a commit
that referenced
this pull request
May 6, 2024
* add rel attributes to external links * adds ssn to the sensitive parameters list (#3733) adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs * fix app scan issues * fix one last app scan issue * use h helper instead of sanitize_html * add spec * add a few missing rel noopener noreferrer attrs to links * add escape to html links * remove redundant rel attr from link --------- Co-authored-by: Sai Kumar Kotagiri <[email protected]> Co-authored-by: TristanB17 <[email protected]>
jacobkagon
pushed a commit
that referenced
this pull request
May 15, 2024
adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs
jacobkagon
pushed a commit
that referenced
this pull request
May 15, 2024
* add rel attributes to external links * adds ssn to the sensitive parameters list (#3733) adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs * fix app scan issues * fix one last app scan issue * use h helper instead of sanitize_html * add spec * add a few missing rel noopener noreferrer attrs to links * add escape to html links * remove redundant rel attr from link --------- Co-authored-by: Sai Kumar Kotagiri <[email protected]> Co-authored-by: TristanB17 <[email protected]>
jacobkagon
pushed a commit
that referenced
this pull request
May 29, 2024
adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs
jacobkagon
pushed a commit
that referenced
this pull request
May 29, 2024
* add rel attributes to external links * adds ssn to the sensitive parameters list (#3733) adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs * fix app scan issues * fix one last app scan issue * use h helper instead of sanitize_html * add spec * add a few missing rel noopener noreferrer attrs to links * add escape to html links * remove redundant rel attr from link --------- Co-authored-by: Sai Kumar Kotagiri <[email protected]> Co-authored-by: TristanB17 <[email protected]>
jacobkagon
pushed a commit
that referenced
this pull request
May 29, 2024
adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs
jacobkagon
pushed a commit
that referenced
this pull request
May 29, 2024
* add rel attributes to external links * adds ssn to the sensitive parameters list (#3733) adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs * fix app scan issues * fix one last app scan issue * use h helper instead of sanitize_html * add spec * add a few missing rel noopener noreferrer attrs to links * add escape to html links * remove redundant rel attr from link --------- Co-authored-by: Sai Kumar Kotagiri <[email protected]> Co-authored-by: TristanB17 <[email protected]>
jacobkagon
pushed a commit
that referenced
this pull request
May 29, 2024
adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs
jacobkagon
pushed a commit
that referenced
this pull request
May 29, 2024
* add rel attributes to external links * adds ssn to the sensitive parameters list (#3733) adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs * fix app scan issues * fix one last app scan issue * use h helper instead of sanitize_html * add spec * add a few missing rel noopener noreferrer attrs to links * add escape to html links * remove redundant rel attr from link --------- Co-authored-by: Sai Kumar Kotagiri <[email protected]> Co-authored-by: TristanB17 <[email protected]>
jacobkagon
pushed a commit
that referenced
this pull request
Jun 12, 2024
adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs
jacobkagon
pushed a commit
that referenced
this pull request
Jun 12, 2024
* add rel attributes to external links * adds ssn to the sensitive parameters list (#3733) adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs * fix app scan issues * fix one last app scan issue * use h helper instead of sanitize_html * add spec * add a few missing rel noopener noreferrer attrs to links * add escape to html links * remove redundant rel attr from link --------- Co-authored-by: Sai Kumar Kotagiri <[email protected]> Co-authored-by: TristanB17 <[email protected]>
jacobkagon
pushed a commit
that referenced
this pull request
Jun 12, 2024
adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs
jacobkagon
pushed a commit
that referenced
this pull request
Jun 12, 2024
* add rel attributes to external links * adds ssn to the sensitive parameters list (#3733) adds ssn to the sensitive parameters list so the value will be replaced with [FILTERED] in the logs * fix app scan issues * fix one last app scan issue * use h helper instead of sanitize_html * add spec * add a few missing rel noopener noreferrer attrs to links * add escape to html links * remove redundant rel attr from link --------- Co-authored-by: Sai Kumar Kotagiri <[email protected]> Co-authored-by: TristanB17 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements
PR Type
What kind of change does this PR introduce?
What is the ticket # detailing the issue?
Ticket: IVL Product Development - 187413531
A brief description of the changes
Current behavior: The value of the SSN is logged without filtering in the logs.
New behavior: The value of the SSN is now logged as
[FILTERED]in the logs asssnis included in the list of filter parameters.Feature Flag
For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and which client(s) it applies to.
Variable name:
Additional Context
I tagged a cucumber as flaky as it has been flickering a lot. A follow-up ticket is created to fix the issue Flickering cucumber fix.
AppScan CodeSweep Failure
In the event of a failed check on the AppScan CodeSweep step of our GitHub Actions workflow, please review the False Positive protocol outlined here: appscan_codesweep/CODESWEEP_FALSE_POSITIVES_README.MD
Add all required notes to this section if the failure is a suspected false positive.