188804152 script src error on broker registration form (#4958)

* fix: add date validation for staff registration form * fix: date validation for staff and agency roles in forms * fix: add key value check for NPN input based on registry feature * fix: add phone number validation for broker contact information
ideacrew · Jan 28, 2025 · c9fcb58 · c9fcb58
1 parent 2a7dd39
commit c9fcb58
Show file tree

Hide file tree

Showing 4 changed files with 51 additions and 13 deletions.
diff --git a/app/assets/javascripts/broker_role.js b/app/assets/javascripts/broker_role.js
@@ -80,7 +80,6 @@ $(document).on('turbolinks:load ajax:success', function () {
 });
 
 function brokerSearch() {
-
   var broker_agency_search = document.getElementById(
     'staff_agency_search'
   ).value;
@@ -114,10 +113,12 @@ function selectBrokereAgency(element) {
   document.getElementById('broker-staff-btn').disabled = false;
 }
 
-
 /// components/benefit_sponsors/app/views/benefit_sponsors/profiles/registrations/new.html.erb
 $(document).on('turbolinks:load ajax:success', function () {
   validateForm();
+  checkDate();
+  checkKeyValue();
+  numKey();
 
   $('#broker_agency_form').tabs({
     activate: function (event, ui) {
@@ -131,6 +132,8 @@ $(document).on('turbolinks:load ajax:success', function () {
             data: { profile_type: 'broker_agency_staff' },
             success: function (data) {
               $('#broker_agency_staff').html(data);
+              const dobInput = document.querySelector('#staff_dob');
+              checkDate();
               indicateRequiredFields();
             },
           });
@@ -162,4 +165,44 @@ $(document).on('turbolinks:load ajax:success', function () {
       }
     },
   });
-});
+});
+
+function checkDate() {
+  const dobInput = document.querySelector(
+    '#staff_dob, #agency_staff_roles_attributes_0_dob'
+  );
+
+  if (dobInput) {
+    // Add event listeners
+    dobInput.addEventListener('blur', function () {
+      validDob(this);
+    });
+  }
+}
+
+function checkKeyValue() {
+  const npnInput = document.getElementById('inputNPN');
+
+  if (npnInput) {
+    npnInput.addEventListener('keypress', function (event) {
+      const isRegistryEnabled =
+        npnInput.dataset.enrollRegistryFeatureEnabled === 'true';
+
+      if (isRegistryEnabled) {
+        isAlphaNumeric(event);
+      } else {
+        isNumberKey(event);
+      }
+    });
+  }
+}
+
+function numKey() {
+  const phoneNum = $('[data-phone-number]');
+
+  if (phoneNum.data('phoneNumber') === true) {
+    phoneNum.on('keypress', function (event) {
+      isNumberKey(event);
+    });
+  }
+}
diff --git a/app/views/ui-components/bs4/v1/forms/broker/_personal_information.html.erb b/app/views/ui-components/bs4/v1/forms/broker/_personal_information.html.erb
@@ -34,9 +34,7 @@
       min: 110.years.ago,
       max: 16.years.ago.beginning_of_month,
       data: {input: "", invalid_dob_title: l10n('broker_agencies.invalid_dob_title'), invalid_dob_body: l10n('broker_agencies.invalid_dob_body'), invalid_dob_after: l10n("broker_agencies.invalid_dob_after", date: 16.years.ago.beginning_of_month.strftime('%m/%d/%Y')), invalid_dob_before: l10n("broker_agencies.invalid_dob_before", date: 110.years.ago.strftime('%m/%d/%Y'))},
-      required: true,
-      onblur: 'validDob(this)',
-      onkeydown: 'storeDateInput(event)'
+      required: true
     %>
     <div class="invalid-feedback">
       <%= l10n("invalid_dob") %>
@@ -51,8 +49,8 @@
       id: 'inputNPN',
       class: 'form-control',
       maxlength: '10',
-      onkeypress: EnrollRegistry.feature_enabled?(:allow_alphanumeric_npn) ? 'return isAlphaNumeric(event);' : 'return isNumberKey(event);',
-      disabled: npn_disabled
+      disabled: npn_disabled,
+      data: {enroll_registry_feature_enabled: EnrollRegistry.feature_enabled?(:allow_alphanumeric_npn) ? 'true' : 'false'}
     %>
     <div class="invalid-feedback">
       <%= l10n('npn_error') %>

diff --git a/app/views/ui-components/bs4/v1/forms/broker/_staff_registration.html.erb b/app/views/ui-components/bs4/v1/forms/broker/_staff_registration.html.erb
@@ -29,9 +29,7 @@
       min: 110.years.ago,
       max: 16.years.ago.beginning_of_month,
       data: {input:"", invalid_dob_title: l10n('broker_agencies.invalid_dob_title'), invalid_dob_body: l10n('broker_agencies.invalid_dob_body'), invalid_dob_after: l10n("broker_agencies.invalid_dob_after", date: 16.years.ago.beginning_of_month.strftime('%m/%d/%Y')), invalid_dob_before: l10n("broker_agencies.invalid_dob_before", date: 110.years.ago.strftime('%m/%d/%Y'))},
-      required: true,
-      onblur: 'validDob(this)',
-      onkeydown: 'storeDateInput(event)'
+      required: true
     %>
     <div class="invalid-feedback">
       <%= l10n("invalid_dob") %>

diff --git a/app/views/ui-components/bs4/v1/forms/broker/contact_information/_phone.html.erb b/app/views/ui-components/bs4/v1/forms/broker/contact_information/_phone.html.erb
@@ -9,9 +9,8 @@
       class: 'form-control phone_number',
       minlength: '14',
       maxlength: '14',
-      onkeypress: 'return isNumberKey(event)',
       value: determine_phone_number(f.object),
-      data: { :"error-message" => phone_error }
+      data: { :"error-message" => phone_error, phone_number: true }
     %>
     <div class="invalid-feedback">
       <%= phone_error %>