only use the first title element for all datatables buttons (#4449)

* only use the first title element * fix security issue
ideacrew · Sep 10, 2024 · 9b00989 · 9b00989
1 parent 7543981
commit 9b00989
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...ms/effective_datatables-2.6.14/app/assets/javascripts/dataTables/buttons/buttons.html5.js b/...ms/effective_datatables-2.6.14/app/assets/javascripts/dataTables/buttons/buttons.html5.js
@@ -339,7 +339,7 @@ var _filename = function ( config, incExtension )
 	}
 
 	if ( filename.indexOf( '*' ) !== -1 ) {
-		filename = $.trim( filename.replace( '*', $('title').text() ) );
+		filename = $.trim( filename.replace( /\*/g, $('title').first().text() ) );
 	}
 
 	// Strip characters which the OS will object to
@@ -380,7 +380,7 @@ var _title = function ( config )
 	}
 
 	return title.indexOf( '*' ) !== -1 ?
-		title.replace( '*', $('title').text() || 'Exported data' ) :
+		title.replace( /\*/g, $('title').first().text() || 'Exported data' ) :
 		title;
 };
 

diff --git a/...ms/effective_datatables-2.6.14/app/assets/javascripts/dataTables/buttons/buttons.print.js b/...ms/effective_datatables-2.6.14/app/assets/javascripts/dataTables/buttons/buttons.print.js
@@ -112,7 +112,7 @@ DataTable.ext.buttons.print = {
 		}
 
 		if ( title.indexOf( '*' ) !== -1 ) {
-			title= title.replace( '*', $('title').first().text() );
+			title= title.replace( /\*/g, $('title').first().text() );
 		}
 
 		win.document.close();