additional transalations and comments fixes

ideacrew · Jan 24, 2025 · 8c2f1a3 · 8c2f1a3
1 parent 17246c4
commit 8c2f1a3
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 11 deletions.
diff --git a/app/helpers/verification_helper.rb b/app/helpers/verification_helper.rb
@@ -340,8 +340,7 @@ def type_unverified?(v_type, person)
   end
 
   def request_response_details_formatted(person, record, v_type)
-    details = {"SSACompositeIndividualResponses"=>[{"ResponseMetadata"=>{"ResponseCode"=>"HS000000", "ResponseDescriptionText"=>"Success", "TDSResponseDescriptionText"=>nil}, "PersonSSNIdentification"=>"534351134", "SSAResponse"=>{"SSNVerificationIndicator"=>true, "DeathConfirmationCode"=>"Unconfirmed", "PersonUSCitizenIndicator"=>true, "PersonIncarcerationInformationIndicator"=>false, "SSATitleIIMonthlyIncomeInformationIndicator"=>nil, "SSATitleIIAnnualIncomeInformationIndicator"=>nil, "SSAQuartersOfCoverageInformationIndicator"=>nil, "SSAIncarcerationInformation"=>nil, "SSATitleIIMonthlyIncome"=>nil, "SSATitleIIYearlyIncome"=>nil, "SSAQuartersOfCoverage"=>nil}}], "ResponseMetadata"=>{"ResponseCode"=>"HS000000", "ResponseDescriptionText"=>"Success", "TDSResponseDescriptionText"=>nil}}
-
+    details = request_response_details(person, record, v_type)
     return unless details.present?
 
     if details.is_a?(Nokogiri::XML::Document)
@@ -453,7 +452,7 @@ def verification_navigation
       "verification" => {title: l10n('insured.families.verifications'), link: main_app.verification_insured_families_path(tab: 'verification')},
       "individual" => {title: 'Individual', link: '#'},
       "verification_detail" => {title: l10n('insured.families.verifications.detail'), link: main_app.verification_detail_insured_families_path(person_id: @evidence.eligibility_state.subject.person_id, eligibility_kind: @evidence.eligibility_state.eligibility_item_key, evidence_key: @evidence.evidence_item_key)},
-      "verification_history" => {title: l10n('Transaction History'), link: '#'}
+      "verification_history" => {title: l10n('insured.families.verifications.history.verification_history'), link: '#'}
     }
 
     current_step_index = steps.keys.find_index(action_name)

diff --git a/app/models/evidence_history_decorator.rb b/app/models/evidence_history_decorator.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-# Represents the history of both an `Eligibilities::Evidence` and a `VerificationType` in a common interface for the `verification_detail` view.
+# Represents the history of both an `Eligibilities::Evidence` and a `VerificationType` in a common interface for the `verification_history` view.
 class EvidenceHistoryDecorator < SimpleDelegator
   include L10nHelper
   include VerificationHelper

diff --git a/app/views/insured/families/verification_detail.html.erb b/app/views/insured/families/verification_detail.html.erb
@@ -103,7 +103,7 @@
     </section>
     <section>
       <h3><%= l10n('view_history') %></h3>
-      <%= link_to 'Verification History', verification_history_insured_families_path(person_id: @evidence.eligibility_state.subject.person_id, eligibility_kind: @evidence.eligibility_state.eligibility_item_key, evidence_key: @evidence.evidence_item_key) %> <%# TODO: implement translation %>
+      <%= link_to l10n('insured.families.verifications.detail.admin_tools.view_history'), verification_history_insured_families_path(person_id: @evidence.eligibility_state.subject.person_id, eligibility_kind: @evidence.eligibility_state.eligibility_item_key, evidence_key: @evidence.evidence_item_key) %>
     </section>
   </section>
 <% end %>
diff --git a/app/views/insured/families/verification_history.html.erb b/app/views/insured/families/verification_history.html.erb
@@ -9,7 +9,7 @@
   } %>
 
 <section class="mb-4">
-  <h2><%= l10n('insured.families.verifications.history.transaction_history') %></h2>
+  <h2><%= l10n('insured.families.verifications.history.verification_history') %></h2>
   <div class="mb-4">
     <table class="action-table" class="col-sm-12 col-md-6" data-controller="expandable-table">
       <thead>
@@ -31,7 +31,7 @@
           <% if record.payload.present? %>
             <tr data-target="expandable-table.details">
               <td colspan="4">
-                <h3>Payload</h3>
+                <h3><%= l10n('insured.families.verifications.history.payload') %></h3>
                 <pre><%= record.payload %> </pre>
               </td>
             </tr>

diff --git a/db/seedfiles/translations/en/dc/insured.rb b/db/seedfiles/translations/en/dc/insured.rb
@@ -424,12 +424,14 @@
   :'en.insured.families.verifications.detail.document.details' => "Document Details",
   :'en.insured.families.verifications.detail.document.uploaded_document' => "Uploaded Document",
   :'en.insured.families.verifications.detail.admin_tools' => "Admin Tools",
+  :'en.insured.families.verifications.detail.admin_tools.view_history' => "View verification history",
   :'en.insured.families.verifications.history.type_header' => "%{verification_type} History",
-  :'en.insured.families.verifications.history.transaction_history' => "Transaction History",
+  :'en.insured.families.verifications.history.verification_history' => "Verification History",
   :'en.insured.families.verifications.history.time_stamp' => "Time Stamp",
   :'en.insured.families.verifications.history.modifier_transaction_id' => "Modifier/Transaction ID",
   :'en.insured.families.verifications.history.action' => "Action",
   :'en.insured.families.verifications.history.update_reason' => "Update Reason",
+  :'en.insured.families.verifications.history.payload' => "Payload",
   :'en.insured.my_coverme_header' => "My CoverME.gov",
   :'en.insured.families.make_a_first_payment' => "Make a first Payment for a new plan",
   :'en.insured.report_a_life_change' => "Report a Life Change",

diff --git a/db/seedfiles/translations/en/me/insured.rb b/db/seedfiles/translations/en/me/insured.rb
@@ -434,12 +434,14 @@
   :'en.insured.families.verifications.detail.document.details' => "Document Details",
   :'en.insured.families.verifications.detail.document.uploaded_document' => "Uploaded Document",
   :'en.insured.families.verifications.detail.admin_tools' => "Admin Tools",
+  :'en.insured.families.verifications.detail.admin_tools.view_history' => "View verification history",
   :'en.insured.families.verifications.history.type_header' => "%{verification_type} History",
-  :'en.insured.families.verifications.history.transaction_history' => "Transaction History",
+  :'en.insured.families.verifications.history.verification_history' => "Verification History",
   :'en.insured.families.verifications.history.time_stamp' => "Time Stamp",
   :'en.insured.families.verifications.history.modifier_transaction_id' => "Modifier/Transaction ID",
   :'en.insured.families.verifications.history.action' => "Action",
   :'en.insured.families.verifications.history.update_reason' => "Update Reason",
+  :'en.insured.families.verifications.history.payload' => "Payload",
   :'en.broker_search_placeholder' => "Name or Agency",
   :'en.insured.my_coverme_header' => "My CoverME.gov",
   :'en.insured.report_a_life_change' => "Report a Life Change",

diff --git a/features/step_definitions/verification_process_steps.rb b/features/step_definitions/verification_process_steps.rb
@@ -82,7 +82,7 @@ def user(*traits)
 end
 
 Then(/^the Transaction History table is present$/) do
-  expect(page).to have_content(l10n('insured.families.verifications.history.transaction_history'))
+  expect(page).to have_content(l10n('insured.families.verifications.history.verification_history'))
 end
 
 And(/^.+ clicks on the back button of the Verification History page$/) do

diff --git a/features/support/env.rb b/features/support/env.rb
@@ -86,7 +86,7 @@
 
 Capybara.register_driver :selenium_chrome do |app|
   options = Selenium::WebDriver::Chrome::Options.new
-  # options.add_argument("headless")
+  options.add_argument("headless")
   options.add_argument("--window-size=1920,1080")
   options.add_argument("--enable-features=NetworkService,NetworkServiceInProcess")