break up values

ideacrew · Dec 16, 2024 · 61cbd14 · 61cbd14
1 parent 6dcbbd5
commit 61cbd14
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/app/helpers/verification_helper.rb b/app/helpers/verification_helper.rb
@@ -294,8 +294,7 @@ def ridp_admin_actions(ridp_type, person)
 
   def build_admin_actions_list(v_type, f_member)
     if EnrollRegistry.feature_enabled?(:ai_an_self_attestation) && v_type.type_name == VerificationType::AMERICAN_INDIAN_STATUS
-      attested_only = ["Verify", "Reject", "Call HUB", "Extend"]
-      ::VlpDocument::ADMIN_VERIFICATION_ACTIONS - attested_only
+      ::VlpDocument::VIEW_HISTORY
     elsif f_member.consumer_role.aasm_state == 'unverified' || VerificationType::ADMIN_CALL_HUB_VERIFICATION_TYPES.exclude?(v_type.type_name)
       ::VlpDocument::ADMIN_VERIFICATION_ACTIONS.reject{ |el| el == 'Call HUB' }
     elsif verification_type_status(v_type, f_member) == 'outstanding'

diff --git a/app/models/vlp_document.rb b/app/models/vlp_document.rb
@@ -31,7 +31,7 @@ class VlpDocument < Document
   #list of the documents user can provide to verify Immigration status
   VLP_DOCUMENT_KINDS = EnrollRegistry[:vlp_documents].setting(:vlp_document_kind_options).item
 
-    VLP_DOCUMENTS_VERIF_STATUS = ['not submitted', 'downloaded', 'verified', 'rejected']
+  VLP_DOCUMENTS_VERIF_STATUS = ['not submitted', 'downloaded', 'verified', 'rejected']
 
   COUNTRIES_LIST = ["Afghanistan", "Albania", "Algeria", "Andorra", "Angola", "Antigua and Barbuda",
                     "Argentina", "Armenia", "Australia", "Austria", "Azerbaijan", "Bahamas", "Bahrain", "Bangladesh",
@@ -60,8 +60,14 @@ class VlpDocument < Document
                     "United States", "Uruguay", "Uzbekistan", "Vanuatu", "Vatican City", "Venezuela", "Viet nam",
                     "Yemen", "Zambia","Zimbabwe"].freeze
 
+  VERIFY = 'Verify'.freeze
+  REJECT = 'Reject'.freeze
+  VIEW_HISTORY = 'View History'.freeze
+  CALL_HUB = 'Call HUB'.freeze
+  EXTEND = 'Extend'.freeze
+
   # admin action list for verification process, dropdown for each verification type
-  ADMIN_VERIFICATION_ACTIONS = ["Verify", "Reject", "View History", "Call HUB", "Extend"]
+  ADMIN_VERIFICATION_ACTIONS = [VERIFY, REJECT, VIEW_HISTORY, CALL_HUB, EXTEND].freeze
 
   # reasons admin can provide when verifying type
   VERIFICATION_REASONS = EnrollRegistry[:verification_reasons].item