Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: update privacy_statement translation remove redundant links (#4004)
* upgrade to bs4 base * revert temp changes for design review to trunk * registration process * more work on consumer flow * fix fonts, more ridp work started * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> * bs4 plan shopping family info & choose cov for HH pages (#3821) * create account page plus additional translations * immigration doc partials * translations for other clients * don't touch FAA yet * app scan warnings * app scan warnings * app scan issues * starting to rubocop * navigation helper rubocop * fix brakeman, other text changes * app scan flags * sanitize links * fix link * devise translations * fix devise translations * devise translations * devise translations * devise translations * devise translations * devise translations * reformat devide translations * reformat devide translations * reformat devide translations * reformat devide translations * redo devise translations * id bad bullets * id bad bullet * id bad bullet * id bad bullet text * previous and continue buttons dryed out * properly sanitize link * fix for no ssn info text * sign in text fix * header contact number not clickable (#3812) add missing href attribute to link * fix personal info step 3 content (#3819) * fix duplicate for, fix missing asterisk for home address fields with introduction of form builder helper that builds a text field which abstracts out setting required field and asterisk append * update helper method to allow callers to not specify class param, fix contact_info_for in other translations * remove unrelated changes * update race legend subtitle to be inline (#3833) move parenthetical to inline with legend title * remove disagree placeholder text (#3831) remove disagree_placeholder_text div * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument * ssn number mask format (#3824) * add mask for ssn, add mask-ssn class on text field * update class name to not be repetitive * use preexisting input mask for ssn * phone number mask format (#3823) * add script tag for phone number mask, add phone_number class on text field, update placeholder to match expected format * replace new mask with a call to inputMasks * add missing underscore prefix to partial (#3840) * right align header account links (#3832) * add ml-auto class to link column * remove unneeded span * adds newline for each span * remove ml-auto class from span and adds align-items-end to both columns * unbold demo info questions (#3836) * localize incarcerated and citizen strings, remove asterisk from tribe_member_2 to allow space and non-space cases, add new selector to allow for unbold form labels and legends * remove asterisk from tribal_name translation * use weight-n instead of new class for enforcing non-bold titles in form * add class for immigrant doc labels * replace header content (#3838) add new devise entry for bs4 welcome message, update controller to drive the flash message using bs4 flag * remove repeated header text (#3839) add translations for user roles, remove fallback on role check in portal helper, use new translation keys in portal helper * rubocop * give continue buttons shared selectors * resolve ticket 187618984 previous button underlined * ridp agreement text bold * disabled dob on more info * session warning pop up * privacy spacing * add not sure for is applying coverage * duplicated *s for aiant question * load correct ridp partials * show help shopping button * progress nav buttons cleanup * auto build feature branch on new changes * fix failed validation page * start fixing rspec failures * continuing spec work * continuing spec work * more spec fixes * ridp admin actions * rubocop fixes * fix warning * make bs4 layout more conditional for dc * bs4 flag for layouts already using bs4 layout * wlecome controller * rubocop * fix address and contact row spacing (#3843) * use margin bottom 2 for first address and contact rows, wrap address hidden fields in span to lose input + label styling * remove span, update selector to disregard hidden inputs * fix contact method alert (#3851) * adds localized string for contact options, update checkbox setup to use unique ids for each option and localize the label, adds missing class on BS4 checkbox span * adds check for non-person which crashed on null check and stopped further validations in the call * remove checked call in combined get * unbold personal info immigration fields (#3852) add weight-n to other status questions legend and all missing immigration doc labels * remove extra personal info contact text (#3850) * fix fonts, more ridp work started * remove unneeded please provide disclaimer label * remove weird merge tag --------- Co-authored-by: Kristin Merbach <[email protected]> * hide id in pre login (#3849) update translation to just be id, update account display to only show id substring when present * fix label for verified state (#3865) update new verification helper to return the string matching legacy for valid case * remove personal info step in consumer signup (#3863) cherry pick old changes * use warning banner for no match (#3861) * update content for bs4, use warning banner * padding updates * rename translation key * add text for missing immigrant status labels (#3864) * adds hardcoded text for missing localized keys * add translations for content * move not sure link below radios (#3870) * use grid for is_applying_for_cov elements * remove rows and reorganize classes * add asterisk to address line 1 and zip in personal info (#3820) * add builder to use for DRYing creation of required text fields with asterisks * update address 1, address 2, city, and zip fields to use the new text_field builder, update zip field to have asterisk * localize city * makes placeholder a required keyword param * rename to RequirableFormBuilder, update helper to maintain both the field/select element and its label, moves asterisk to label per specs * fixe merge order so that params override options * remove formbuilder and hardcode asterisks in markup * fix trailing whitespace, remove county translation * restore add 1 class * use required class for required fields * add required attr for city * add disabled class to continue link (#3872) * add disabled class to link, remove extraneous if in button * restores disabled if for button case * fix missing document faq button (#3877) * 187579400 update flash (#3854) * add BS4 view to flash partial * updates flash partial for bs4, updates progress and bs4 layouts to render new flash * fix underscore on close button * close icon work * white space fix * map legacy alert type to bs4, update flash layout to work well with larger messages, accessibility updates * add success case, more whitespace cleanup * update alert-error to use correct border and add error icon * move container out of layout, update padding on header to match footer * update padding and margins on flash * simplify flash in progress layout now that we have flash in its own container * unrelated fix for failed validations, replace old alert style, add missing legacy style in BS4 flash style map, add new alert style, update flash margin, * adds @bs4 arguments for render_flash calls and restores horizontal status in bs4 layout * rename flash type helper method * update info step 1 banner (#3860) * adds warning option to DOB error, updates error_messages partial to handle error option and use new UI * remove left padding for list in alert * remove unneeded classes * remove padding style * updates classes for error banner to match mockups * move flash into content column for progress layout, remove mt class from flash to allow layouts to drive top margin * ridp default select agree (#3878) add selected args for radio buttons * resolve spacing issues (#3875) * fix spacing, style the info to match other info boxes * more spacing * consolidate spacing classes * session modal styling (#3874) * session modal styling * remove unnecessary span * consolidate spacing classes * ridp waiting * update upload doc verify identity modal (#3886) * split modal partial for bs4, finish header * add radios and upload/close buttons * padding update * update radio text to be blocked and centered with radio * more padding and margin fixes * padding update for info label * use for to render radios * add id * remove unneeded value attr * remove unneeded classes on button row * refactor radio value and id * use element name for legend * removes for from legend * remove row * move btn-file selector to forms * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> * improve ridp status badges (#3884) * temp * improve ridp status badges * improve encapsulation * rename of vars * rename vars 2.0 * ridp fixes for previous and log out links (#3879) * ridp link fixes * button link hovers shouldn't have underline * fix add mailing address functionality (#3876) * fix mailing address js * remove console log * add button for existing mailing addresses * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> * fix fonts, more ridp work started * choose cov page wip * plan shopping progress bars updated * plan shopping nav refactoring * remove debug line * choose cov for hh progress, added pg nav buttons for first flow * family information page progress * family information conversion, fixed progress nav buttons * translation fixes * removed debugging code * convert to html.erb * rebase cleanup * removed duped code & unnecessary vars, erb convert for ps compare modal * fix link_to CSS vunerabilities * baseline post convrsion * plan shopping progress refactor * Bootstrap misc bugfixes (#3895) fixes for 6 bug tickets * pr feedback, small fixes * upgrade to bs4 base * revert temp changes for design review to trunk * add feature flag and switch consumer role controler layout * personal information page redo * feature flags, faa layouts * bs4 footer * fix for dynamic footer * header wip, stable * header progress * sticky footer fix * header logo update, move styling to new file * add bs4 upgrade icons, collapsed header tweaks * started family information * privacy page and personal information, button mixin * registration process * more work on consumer flow * fix semicolon * client specific files re-organized * authorization & consent page * footer updates * footer phone # fix * authority & consent ridp page * progress nav accessibility * fix fonts, more ridp work started * added ME colors, revert app controller flag * ridp flow * add new progress layout * create account page plus additional translations * immigration doc partials * translations for other clients * don't touch FAA yet * app scan warnings * app scan warnings * app scan issues * starting to rubocop * navigation helper rubocop * fix brakeman, other text changes * app scan flags * sanitize links * fix link * devise translations * fix devise translations * devise translations * devise translations * devise translations * devise translations * devise translations * reformat devide translations * reformat devide translations * reformat devide translations * reformat devide translations * redo devise translations * id bad bullets * id bad bullet * id bad bullet * id bad bullet text * previous and continue buttons dryed out * properly sanitize link * fix for no ssn info text * sign in text fix * header contact number not clickable (#3812) add missing href attribute to link * fix personal info step 3 content (#3819) * fix duplicate for, fix missing asterisk for home address fields with introduction of form builder helper that builds a text field which abstracts out setting required field and asterisk append * update helper method to allow callers to not specify class param, fix contact_info_for in other translations * remove unrelated changes * update race legend subtitle to be inline (#3833) move parenthetical to inline with legend title * remove disagree placeholder text (#3831) remove disagree_placeholder_text div * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument * ssn number mask format (#3824) * add mask for ssn, add mask-ssn class on text field * update class name to not be repetitive * use preexisting input mask for ssn * phone number mask format (#3823) * add script tag for phone number mask, add phone_number class on text field, update placeholder to match expected format * replace new mask with a call to inputMasks * add missing underscore prefix to partial (#3840) * right align header account links (#3832) * add ml-auto class to link column * remove unneeded span * adds newline for each span * remove ml-auto class from span and adds align-items-end to both columns * unbold demo info questions (#3836) * localize incarcerated and citizen strings, remove asterisk from tribe_member_2 to allow space and non-space cases, add new selector to allow for unbold form labels and legends * remove asterisk from tribal_name translation * use weight-n instead of new class for enforcing non-bold titles in form * add class for immigrant doc labels * replace header content (#3838) add new devise entry for bs4 welcome message, update controller to drive the flash message using bs4 flag * remove repeated header text (#3839) add translations for user roles, remove fallback on role check in portal helper, use new translation keys in portal helper * rubocop * give continue buttons shared selectors * resolve ticket 187618984 previous button underlined * ridp agreement text bold * disabled dob on more info * session warning pop up * privacy spacing * add not sure for is applying coverage * duplicated *s for aiant question * load correct ridp partials * show help shopping button * progress nav buttons cleanup * auto build feature branch on new changes * fix failed validation page * start fixing rspec failures * continuing spec work * continuing spec work * more spec fixes * ridp admin actions * rubocop fixes * fix warning * make bs4 layout more conditional for dc * bs4 flag for layouts already using bs4 layout * wlecome controller * rubocop * fix address and contact row spacing (#3843) * use margin bottom 2 for first address and contact rows, wrap address hidden fields in span to lose input + label styling * remove span, update selector to disregard hidden inputs * fix contact method alert (#3851) * adds localized string for contact options, update checkbox setup to use unique ids for each option and localize the label, adds missing class on BS4 checkbox span * adds check for non-person which crashed on null check and stopped further validations in the call * remove checked call in combined get * unbold personal info immigration fields (#3852) add weight-n to other status questions legend and all missing immigration doc labels * remove extra personal info contact text (#3850) * fix fonts, more ridp work started * remove unneeded please provide disclaimer label * remove weird merge tag --------- Co-authored-by: Kristin Merbach <[email protected]> * hide id in pre login (#3849) update translation to just be id, update account display to only show id substring when present * fix label for verified state (#3865) update new verification helper to return the string matching legacy for valid case * remove personal info step in consumer signup (#3863) cherry pick old changes * use warning banner for no match (#3861) * update content for bs4, use warning banner * padding updates * rename translation key * add text for missing immigrant status labels (#3864) * adds hardcoded text for missing localized keys * add translations for content * move not sure link below radios (#3870) * use grid for is_applying_for_cov elements * remove rows and reorganize classes * add asterisk to address line 1 and zip in personal info (#3820) * add builder to use for DRYing creation of required text fields with asterisks * update address 1, address 2, city, and zip fields to use the new text_field builder, update zip field to have asterisk * localize city * makes placeholder a required keyword param * rename to RequirableFormBuilder, update helper to maintain both the field/select element and its label, moves asterisk to label per specs * fixe merge order so that params override options * remove formbuilder and hardcode asterisks in markup * fix trailing whitespace, remove county translation * restore add 1 class * use required class for required fields * add required attr for city * add disabled class to continue link (#3872) * add disabled class to link, remove extraneous if in button * restores disabled if for button case * fix missing document faq button (#3877) * 187579400 update flash (#3854) * add BS4 view to flash partial * updates flash partial for bs4, updates progress and bs4 layouts to render new flash * fix underscore on close button * close icon work * white space fix * map legacy alert type to bs4, update flash layout to work well with larger messages, accessibility updates * add success case, more whitespace cleanup * update alert-error to use correct border and add error icon * move container out of layout, update padding on header to match footer * update padding and margins on flash * simplify flash in progress layout now that we have flash in its own container * unrelated fix for failed validations, replace old alert style, add missing legacy style in BS4 flash style map, add new alert style, update flash margin, * adds @bs4 arguments for render_flash calls and restores horizontal status in bs4 layout * rename flash type helper method * update info step 1 banner (#3860) * adds warning option to DOB error, updates error_messages partial to handle error option and use new UI * remove left padding for list in alert * remove unneeded classes * remove padding style * updates classes for error banner to match mockups * move flash into content column for progress layout, remove mt class from flash to allow layouts to drive top margin * ridp default select agree (#3878) add selected args for radio buttons * resolve spacing issues (#3875) * fix spacing, style the info to match other info boxes * more spacing * consolidate spacing classes * session modal styling (#3874) * session modal styling * remove unnecessary span * consolidate spacing classes * ridp waiting * update upload doc verify identity modal (#3886) * split modal partial for bs4, finish header * add radios and upload/close buttons * padding update * update radio text to be blocked and centered with radio * more padding and margin fixes * padding update for info label * use for to render radios * add id * remove unneeded value attr * remove unneeded classes on button row * refactor radio value and id * use element name for legend * removes for from legend * remove row * move btn-file selector to forms * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> * improve ridp status badges (#3884) * temp * improve ridp status badges * improve encapsulation * rename of vars * rename vars 2.0 * ridp fixes for previous and log out links (#3879) * ridp link fixes * button link hovers shouldn't have underline * fix add mailing address functionality (#3876) * fix mailing address js * remove console log * add button for existing mailing addresses * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> * Bootstrap misc bugfixes (#3895) fixes for 6 bug tickets * update bs4 content for dob personal info banner (#3883) * update corner radius for bs4 alerts, localize dob error, switch on message when validating dob for bs4 flag * use existing continue strings as substring in dob error * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup * FAA eligibility results to bs4 (#3894) * eligibility results * waiting for eligibility * wait for results --------- Signed-off-by: kristinmerbach <[email protected]> * add member to family fix * main.scss brace fix, cleanup * webpacker depreciation warning cleanup * fix build error with calc * revert sass depreciation fix attempt * small transation & inline style fixes * XSS fixes --------- Signed-off-by: kristinmerbach <[email protected]> Signed-off-by: Sarah Austin <[email protected]> Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Charlie Parker <[email protected]> Co-authored-by: kvootla <[email protected]> Co-authored-by: Alec Turnbull <[email protected]> Co-authored-by: kristinmerbach <[email protected]> Co-authored-by: Alec Turnbull <[email protected]> * bs4 income adjustments (#3954) * todos * add red required asterisk mc * remove date debug comments * remove newline * more section work mc * work through coverage mc * remove hack for frozen string and update displayable_field? mc * add income table * translation work, use existing gray colors for table borders mc * modal work * fix modal id * modal title fix * continue text for mec banner * coverage required fixes mc * move caretaker string to review section mc * translation cleanup * more localization work mc * fix hover color * fix asterisk * m mcodernize review_benefits partial (need to remove debug) * debug removal, translation esi work mc * move esi fields to partial * add bottom sections mc * fix formatted string * add subsection partial * pass in applicant for summary section mc * move hash helpers to new file mc * add translation helper for review and submit hashes mc * add private helpers for displayable field and add missing row map calls for foster care keys * move translator module into helper module, fix displayable helper callers for applicant * cleanup mc * use key for expected * fix caretaker key, view cleanup mc * use human boolean for parent outside * undo rebase issue * fix continue application content * add missing upcase * undo lock file change * update hover * remove todo * titleize relationship, add helpers for hash constructors * classify displayable helpers * remove class_name method * add include, fix wrong variable name for relationship builder * remove unneeded helper declaration * remove newline Signed-off-by: Charlie Parker <[email protected]> * add bs4 outline to view, logic to controller mc * inital review work - update controller to support action, implement Personal Info and Tax rows mc mc * fix for review and submit layout mc * move selectric handling to js for other questions * initial page work mc * update form, update date formatting for date fields, disable selectric on drop downs * save cancel button work * remove debug * remove unneeded ids, fix error on translations but still need correct content mc * add nav, update form partial to default save button to disabled * fix save button and form disabling * fix add more link permeance after removal * fix created income UI showing legacy, fix edit button not working * remove unneeded bs4 set * move other actions to conditional mc * add date field for income, fix bug causing fake input fields to be enabled upon edit -> cancel flow * use date field for unemployment * fix add button permeance bug after remove for unemployment mc * cleanup mc * update disable for deductions * cleanup * cancel fix, other income form class fixes * fix cancel button reseting checkbox bug, update padding for elements in form partials to be consistent with non-form partials * update edit and remove buttons for deductions, remove repeated edit class for other income * swap id and class for add more button in both legacy and bs4 * add missing enable from rebase * add missing when from rebase * fix destroy/destroy all handling to ensure permeance of add new button when there are still other deductions for the kind, fix replace bug that caused the add new button to be hidden when adding a new deduction after deleting a deduction * update add new button hiding * button fixes - use outline for remove and use button class for edit to allow edit disabling * remove add more on destroy all * modal and translation work * add logic to reset deduction form when empty and uncheck * edit, cancel, add new fixes for other income * fix deduction remove not causing checkbox reset, break out deduction kind remove to function, refactor deduction kind remove to handle concurrency * disable all income edit buttons while editing for other/unemployment along with class update to btn to allow disable, start selector syntax fix for removeDeduction method, add removeIncome method, add other income checkbox uncheck handling for no created deductions case, button styling fix for modals * support add new disable for unemployment, remove unneeded selector from replace, margin fixes for unemployment cancel and unemployment add more * support add more disable for other income * margin fixes for buttons, apply other income add disable universally * add more fixes * add progress button disable functionality * fix new form permeating when removing all deduction kinds, fix add more permeating when unchecking kind with open form * fix other income add more permeating when unchecking kind with an income and form, fix doubling up of income when creating income after removing all kind with an income and form * cleanup cancel, fix unemployment add more to not appear for initial entry * remove cleanup * add legacy handling for deductions * hide add more on cancel when no other existing * auto uncheck unemployment on final delete, fix cancel handling * fix add more permeance for cancel new deduction, break out reset into function, update income edit disabling to account for unemployment * selector fixes, make frequency required * update modals and allow disabling of a tags * fix broken translation * translation cleanup for me, remove labels from subsection partial and replace with dl, add required class for dt * rename key string * remove unneeded style * remove unused strings * update margins of form buttons and checkboxes to match mockups * remove add new deduction bottom margin, add x margin for deduction/other driver radios, update deduction form edit/create to disable remove button of other forms * restructure other markup, update save input class to button to match disabled styling, disable remove button for income.js when editing * class fixes * update edit toggling selectors to not disable divs which directly own buttons * ss string fix * fix leave warning modal * cleanup * add support for ai an * set deductions actions from params * restore legacy add replace * consolidate add link * update disabled style to select all bottom level, non a & button elements so that a & buttons can be individually styled, update new form cloning to prevent multiple form label error * remove debug * comment fixes * update forms to validate date warnings using bs4 date format, add date warning UI for bs4, update date warning content to match mockups * fix date parsing for bs4 * income note field work * add end date translation * fix syntax error * remove unneeded keys from merge * fix legacy income note * translation cleanup * update leave edit to not enable submit buttons, remove redundant disable on fake inputs * more translation cleanup * disable help links * fix review description list * cleanup * fix unemployment edit delete * fix date parsing * update other questions date parsing * modal work * add date warning to other income, remove undefined check in js * move warning partials * flex work * rollback debug * remove extra semi colon * disable yes/no text * remove left margins on inputs * more margin updates * remove margin on unemployment add more * add leave ids --------- Signed-off-by: Charlie Parker <[email protected]> * uplift job income page to bs4 (#3974) * personal information page redo * job income changes * missing translations * updates to translation * cleanup unneeded class changes * remove extra changed file * more cleanup * changes from PR comments * fixed * header sizing order issue * remove br * small nav bug for nonbs4 * improve spacing * fix income_kind * clean up nits * phone input masking * more changings --------- Co-authored-by: Kristin Merbach <[email protected]> * fix: update privacy_statement translation remove redundant links --------- Signed-off-by: kristinmerbach <[email protected]> Signed-off-by: Sarah Austin <[email protected]> Signed-off-by: Charlie Parker <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: kristinmerbach <[email protected]> Co-authored-by: Charlie Parker <[email protected]> Co-authored-by: kvootla <[email protected]> Co-authored-by: Alec Turnbull <[email protected]> Co-authored-by: Alec Turnbull <[email protected]>
- Loading branch information
8 people
committed
Sep 13, 2024
1 parent
fdb2b3c
commit 48ab9ed