Skip to content

Commit

Permalink
bs4 add outline for missing (#4214)
Browse files Browse the repository at this point in the history
* add check for nil relation

* remove missing banner
  • Loading branch information
charlienparker authored Aug 6, 2024
1 parent fe2f5fe commit 34c1714
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ def find_all_relationships(matrix)
next unless xi < yi
relation = relationships.where(applicant_id: id_map[xi], relative_id: id_map[yi]).first
relation_kind = relation&.kind
relation_has_error = invalid_ids.include?(relation&.id)
relation_has_error = invalid_ids.include?(relation&.id) || relation_kind.nil?
all_relationships << {:applicant => id_map[xi], :relation => relation_kind, :relative => id_map[yi], :error => relation_has_error}
end
end
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,5 @@
<% if @bs4 %>
<%= render partial: '/financial_assistance/shared/faa_progress_options', locals: {step: 2} %>
<% if @missing_relationships.any? %>
<div class="alert alert-error d-flex" role="alert">
<div>
<div class="error-icon icon mt-3" alt="error" aria-hidden="true">&nbsp;</div>
</div>
<div class="mt-2 mb-1">
<p><%= l10n("faa.review.your_household.relationships_error") %></p>
</div>
</div>
<% end %>
<h1><%= l10n("family_relationships") %></h1>
<p>
<%= l10n("household_relationships") %>
Expand Down

0 comments on commit 34c1714

Please sign in to comment.