Updates to scenarios for Insured consumer flow dc (#3990)

* update admin consumer steps * update pom libaries * disable bs4 for individual features * diable bs4 consumer flow insured folder dc * update disable bs4 for dc * update scenarios for dc client * update scenarios for dc and maine * update scenarios for dc * update maine and dc scenarios * update dc account creation steps * remove unnecessarry comments #binding.irb * update wait for eligiblity response feature for maine and dc * update account creation feature for dc * update documents_page feature for dc * update household coverage page feature for dc * update message pages feature for dc * update individual_sep_signup feature for dc * update contast level aa scenarios for maine * update help_me_sign_up_steps * update dc insured scenarios * update other income scenarios for dc * update individual_sep_signup scenarios for dc * update individual_with_existing_sep scenarios for dc * add wait to individual steps for dc * disable bs4 changes for manage family personal information dc * update ageoff_sep_employee_adding_dependent scenario for dc * update household_info_continue_button_steps for dc * update health_coverage scenario * update continue button for dc * udate contrast level aa scenarios and remove comments from feature file * update comments around bugs introduce with details * update individual steps for maine * update job income steps for dc * update job income POM * update health coverage pom locators * fix health coverage eligible question * print cucumber failures in summary (#3987) * adding cucumber failures to summary * trying another way to pipe it * trying with tee instead of just redirection * tee didn't work * print error on screen too * update accessbility scenarios * more FAA cleanup * tax info continue button selector * tax info scnearios * missing translations * waiting for results cucumber * start on manage seps * don't use new bootstrap layout * convert response_id to string * more welcome screen work * ridp continue button * proper log out location * update individual steps for dc --------- Co-authored-by: Diana Quisbert <[email protected]> Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Marco (Polo) Ornelas <[email protected]> Co-authored-by: Alec Turnbull <[email protected]>
ideacrew · Sep 4, 2024 · 32a9e5b · 32a9e5b
1 parent 6af1cb0
commit 32a9e5b
Show file tree

Hide file tree

Showing 101 changed files with 703 additions and 280 deletions.
diff --git a/app/controllers/exchanges/manage_sep_types_controller.rb b/app/controllers/exchanges/manage_sep_types_controller.rb
@@ -8,9 +8,9 @@ class ManageSepTypesController < ApplicationController
 
     before_action :set_cache_headers, only: [:sep_types_dt, :sorting_sep_types, :clone, :new, :edit]
     before_action :updateable?
-    layout 'single_column', except: [:new, :edit, :create, :update, :sorting_sep_types, :clone]
+    layout 'application', except: [:new, :edit, :create, :update, :sorting_sep_types, :clone]
     layout 'bootstrap_4', only: [:new, :edit, :create, :update, :sorting_sep_types, :clone]
-    before_action :enable_bs4_layout, only: [:new, :edit, :create, :update, :sorting_sep_types, :clone] if EnrollRegistry.feature_enabled?(:bs4_consumer_flow)
+    # before_action :enable_bs4_layout, only: [:new, :edit, :create, :update, :sorting_sep_types, :clone] if EnrollRegistry.feature_enabled?(:bs4_consumer_flow)
 
     def new
       @qle = Forms::QualifyingLifeEventKindForm.for_new

diff --git a/app/controllers/users/registrations_controller.rb b/app/controllers/users/registrations_controller.rb
@@ -6,6 +6,7 @@ class Users::RegistrationsController < Devise::RegistrationsController
   layout 'bootstrap_4'
 
   before_action :enable_bs4_layout, only: [:create, :new] if EnrollRegistry.feature_enabled?(:bs4_consumer_flow)
+  before_action :enable_updated_layout, only: [:create, :new]
   before_action :configure_sign_up_params, only: [:create]
   before_action :set_ie_flash_by_announcement, only: [:new]
 
@@ -133,4 +134,8 @@ def enable_bs4_layout
     @bs4 = true
   end
 
+  def enable_updated_layout
+    @use_bs4_layout = true
+  end
+
 end
diff --git a/app/controllers/users/sessions_controller.rb b/app/controllers/users/sessions_controller.rb
@@ -5,6 +5,7 @@ class Users::SessionsController < Devise::SessionsController
   after_action :log_failed_login, :only => :new
   before_action :set_ie_flash_by_announcement, only: [:new]
   before_action :enable_bs4_layout, only: [:create, :new] if EnrollRegistry.feature_enabled?(:bs4_consumer_flow)
+  before_action :enable_updated_layout, only: [:create, :new]
 
   def new
     super do
@@ -55,4 +56,8 @@ def failed_login?
   def enable_bs4_layout
     @bs4 = true
   end
+
+  def enable_updated_layout
+    @use_bs4_layout = true
+  end
 end
diff --git a/app/controllers/welcome_controller.rb b/app/controllers/welcome_controller.rb
@@ -4,6 +4,7 @@ class WelcomeController < ApplicationController
   layout 'bootstrap_4'
   skip_before_action :require_login
   before_action :set_cookie_attributes, only: [:index]
+  before_action :enable_bs4_layout, only: [:index]
 
   def show_hints
     current_user.hints = !current_user.hints
@@ -30,4 +31,8 @@ def set_cookie_attributes
     response.headers['Strict-Transport-Security'] = "max-age=31536000; includeSubDomains; preload"
   end
 
+  def enable_bs4_layout
+    @bs4 = true
+  end
+
 end
diff --git a/app/helpers/consumer_roles_helper.rb b/app/helpers/consumer_roles_helper.rb
@@ -88,6 +88,6 @@ def ridp_redirection_link(person)
     id_verified = consumer.identity_verified?
     app_verified = consumer.application_verified?
     return consumer_redirection_path if app_verified || id_verified
-    consumer.admin_bookmark_url
+    consumer.admin_bookmark_url.present? ? consumer.admin_bookmark_url : request.env['PATH_INFO']
   end
 end
diff --git a/app/views/insured/fdsh_ridp_verifications/_outstanding_ridp_documents.html.erb b/app/views/insured/fdsh_ridp_verifications/_outstanding_ridp_documents.html.erb
@@ -178,6 +178,7 @@
               </div>
             </div>
           </div>
+        </div>
     </div>
   </div>
 

diff --git a/app/views/layouts/bootstrap_4.html.erb b/app/views/layouts/bootstrap_4.html.erb
@@ -1,82 +1,150 @@
-<!DOCTYPE html>
-<!-- extract to helper rather than use the ENV directly -->
-<html lang="en" data-theme="<%= ENV['CLIENT'] %>" data-contrast="<%= EnrollRegistry.feature_enabled?(:contrast_level_aa) %>" data-bs4="<%= @bs4 %>">
-  <head>
-    <meta charset="utf-8">
-    <meta http-equiv="X-UA-Compatible" content="IE=Edge">
-    <meta name="viewport" content="width=device-width, initial-scale=1.0">
-    <%= favicon_link_tag Settings.site.tab_icon, :rel => 'shortcut icon', :type => EnrollRegistry[:enroll_app].settings(:favicon_tab_icon).item %>
-
-    <title><%= content_for?(:title) ? yield(:title) : "Welcome to #{site_short_name} | #{site_short_name}" %></title>
-
-
-    <%= javascript_pack_tag 'application', 'data-turbolinks-track': 'reload' %>
-    <%= javascript_include_tag "application", 'data-turbolinks-track': 'reload' %>
-    <%= stylesheet_pack_tag 'application', 'data-turbolinks-track': 'reload' %>
-    <%= javascript_pack_tag ENV['CLIENT'], 'data-turbolinks-track': 'reload' %>
-    <%= stylesheet_pack_tag ENV['CLIENT'], 'data-turbolinks-track': 'reload' %>
-
-    <% if EnrollRegistry.feature_enabled?(:contrast_level_aa) %>
-      <%= javascript_pack_tag 'contrast_level_aa' %>
-      <%= stylesheet_pack_tag 'contrast_level_aa' %>
-    <% end %>
+<% if @bs4 || @use_bs4_layout %>
+  <!DOCTYPE html>
+  <!-- extract to helper rather than use the ENV directly -->
+  <html lang="en" data-theme="<%= ENV['CLIENT'] %>" data-contrast="<%= EnrollRegistry.feature_enabled?(:contrast_level_aa) %>" data-bs4="<%= @bs4 %>">
+    <head>
+      <meta charset="utf-8">
+      <meta http-equiv="X-UA-Compatible" content="IE=Edge">
+      <meta name="viewport" content="width=device-width, initial-scale=1.0">
+      <%= favicon_link_tag Settings.site.tab_icon, :rel => 'shortcut icon', :type => EnrollRegistry[:enroll_app].settings(:favicon_tab_icon).item %>
 
-    <%= action_cable_meta_tag %>
-    <%= csrf_meta_tags %>
+      <title><%= content_for?(:title) ? yield(:title) : "Welcome to #{site_short_name} | #{site_short_name}" %></title>
 
-    <% if EnrollRegistry.feature_enabled?(:live_chat_widget) %>
-      <%= render "shared/customer_support/live_chat_scripts" unless EnrollRegistry.feature_enabled?(:external_qna_bot) %>
-    <% end %>
 
-    <!-- HTML5 shim and Respond.js for IE8 support of HTML5 elements and media queries -->
-    <!-- WARNING: Respond.js doesn't work if you view the page via file:// -->
-    <!--[if lt IE 9]>
-      <script src="https://oss.maxcdn.com/html5shiv/3.7.2/html5shiv.min.js"></script>
-      <script src="https://oss.maxcdn.com/respond/1.4.2/respond.min.js"></script>
-    <![endif]-->
+      <%= javascript_pack_tag 'application', 'data-turbolinks-track': 'reload' %>
+      <%= javascript_include_tag "application", 'data-turbolinks-track': 'reload' %>
+      <%= stylesheet_pack_tag 'application', 'data-turbolinks-track': 'reload' %>
+      <%= javascript_pack_tag ENV['CLIENT'], 'data-turbolinks-track': 'reload' %>
+      <%= stylesheet_pack_tag ENV['CLIENT'], 'data-turbolinks-track': 'reload' %>
 
-    <%= render "layouts/analytics" if ENV['GA_TRACKING_ID'].present? %>
-  </head>
-  <body class="font <%= ENV['CLIENT'] || "ic" %>-sbm d-flex flex-column justify-content-between min-vh-100">
-    <%= render partial: './ui-components/bs4/v1/navs/header' %>
+      <% if EnrollRegistry.feature_enabled?(:contrast_level_aa) %>
+        <%= javascript_pack_tag 'contrast_level_aa' %>
+        <%= stylesheet_pack_tag 'contrast_level_aa' %>
+      <% end %>
 
-    <%= yield :horizontal_menu %>
+      <%= action_cable_meta_tag %>
+      <%= csrf_meta_tags %>
 
-    <main class="pb-5 <%= controller_name %> flex-grow-1">
-      <% if aca_security_questions %>
-        <%= render 'users/security_question_responses/modal' %>
+      <% if EnrollRegistry.feature_enabled?(:live_chat_widget) %>
+        <%= render "shared/customer_support/live_chat_scripts" unless EnrollRegistry.feature_enabled?(:external_qna_bot) %>
       <% end %>
 
-      <div class=<%= "mt-4" if @bs4 %>>
-       <%= render_flash use_bs4: @bs4 %>
-      </div>
+      <!-- HTML5 shim and Respond.js for IE8 support of HTML5 elements and media queries -->
+      <!-- WARNING: Respond.js doesn't work if you view the page via file:// -->
+      <!--[if lt IE 9]>
+        <script src="https://oss.maxcdn.com/html5shiv/3.7.2/html5shiv.min.js"></script>
+        <script src="https://oss.maxcdn.com/respond/1.4.2/respond.min.js"></script>
+      <![endif]-->
+
+      <%= render "layouts/analytics" if ENV['GA_TRACKING_ID'].present? %>
+    </head>
+    <body class="font <%= ENV['CLIENT'] || "ic" %>-sbm d-flex flex-column justify-content-between min-vh-100">
+      <%= render partial: './ui-components/bs4/v1/navs/header' %>
+
+      <%= yield :horizontal_menu %>
+
+      <main class="pb-5 <%= controller_name %> flex-grow-1">
+        <% if aca_security_questions %>
+          <%= render 'users/security_question_responses/modal' %>
+        <% end %>
 
-      <aside class="container">
-        <%= yield :horizontal_status %>
-      </aside>
+        <div class=<%= "mt-4" if @bs4 %>>
+        <%= render_flash use_bs4: @bs4 %>
+        </div>
 
-      <% if content_for? :content %>
-        <%= yield :content %>
+        <aside class="container">
+          <%= yield :horizontal_status %>
+        </aside>
+
+        <% if content_for? :content %>
+          <%= yield :content %>
+        <% else %>
+          <%= yield %>
+        <% end %>
+      </main>
+      <% if @bs4 %>
+        <%= render partial: './ui-components/bs4/v1/footers/footer' %>
       <% else %>
-        <%= yield %>
+        <%= render partial: './ui-components/v1/layouts/footer' %>
+      <% end %>
+      <% if EnrollRegistry.feature_enabled?(:jquery_migrate) %>
+        <% if EnrollRegistry[:jquery_migrate].setting(:show_warnings).item == true %>
+          <script src="https://code.jquery.com/jquery-migrate-3.4.1.js"></script>
+        <% else %>
+          <script src="https://code.jquery.com/jquery-migrate-3.4.1.min.js"></script>
+        <% end %>
       <% end %>
-    </main>
+    </body>
     <% if @bs4 %>
-      <%= render partial: './ui-components/bs4/v1/footers/footer' %>
-    <% else %>
-      <%= render partial: './ui-components/v1/layouts/footer' %>
+      <script>
+        disableSelectric = true;
+      </script>
     <% end %>
-    <% if EnrollRegistry.feature_enabled?(:jquery_migrate) %>
-      <% if EnrollRegistry[:jquery_migrate].setting(:show_warnings).item == true %>
-        <script src="https://code.jquery.com/jquery-migrate-3.4.1.js" integrity="sha384-cG5RCHYtwmrSoNV1o0el92fuszs0g3Q7LmgwVE5f6u2Yn/LWDcUeEsDdmAhV0D3e" crossorigin="anonymous"></script>
-      <% else %>
-        <script src="https://code.jquery.com/jquery-migrate-3.4.1.min.js" integrity="sha384-ez4i72z0XhJqm0ZRoQkpPN0bDV8Kw8PK3n8kjEZsWhRDrfICLd0AGghHJB+vytx0" crossorigin="anonymous"></script>
+  </html>
+<% else %>
+  <!DOCTYPE html>
+  <html lang="en">
+    <head>
+      <meta charset="utf-8">
+      <meta http-equiv="X-UA-Compatible" content="IE=Edge">
+      <meta name="viewport" content="width=device-width, initial-scale=1.0">
+      <%= favicon_link_tag Settings.site.tab_icon, :rel => 'shortcut icon', :type => EnrollRegistry[:enroll_app].settings(:favicon_tab_icon).item %>
+
+      <title><%= content_for?(:title) ? yield(:title) : "Welcome to #{site_short_name} | #{site_short_name}" %></title>
+
+
+      <%= javascript_pack_tag 'application', 'data-turbolinks-track': 'reload' %>
+      <%= stylesheet_pack_tag 'application', 'data-turbolinks-track': 'reload' %>
+      <%= javascript_pack_tag ENV['CLIENT'], 'data-turbolinks-track': 'reload' %>
+      <%= stylesheet_pack_tag ENV['CLIENT'], 'data-turbolinks-track': 'reload' %>
+
+      <% if EnrollRegistry.feature_enabled?(:contrast_level_aa) %>
+        <%= javascript_pack_tag 'contrast_level_aa' %>
+        <%= stylesheet_pack_tag 'contrast_level_aa' %>
       <% end %>
-    <% end %>
-  </body>
-  <% if @bs4 %>
-    <script>
-      disableSelectric = true;
-    </script>
-  <% end %>
- </html>
+
+      <%= action_cable_meta_tag %>
+      <%= csrf_meta_tags %>
+      <% if EnrollRegistry.feature_enabled?(:live_chat_widget) %>
+        <%= render "shared/customer_support/live_chat_scripts" unless EnrollRegistry.feature_enabled?(:external_qna_bot) %>
+      <% end %>
+      <!-- HTML5 shim and Respond.js for IE8 support of HTML5 elements and media queries -->
+        <!-- WARNING: Respond.js doesn't work if you view the page via file:// -->
+        <!--[if lt IE 9]>
+          <script src="https://oss.maxcdn.com/html5shiv/3.7.2/html5shiv.min.js"></script>
+          <script src="https://oss.maxcdn.com/respond/1.4.2/respond.min.js"></script>
+        <![endif]-->
+
+      <%= render "layouts/analytics" if ENV['GA_TRACKING_ID'].present? %>
+
+    </head>
+    <body class="font <%= ENV['CLIENT'] || "ic" %>-sbm">
+      <%= render partial: './ui-components/bs4/v1/navs/header' %>
+
+      <%= yield :horizontal_menu %>
+
+      <div class="content <%= controller_name %> content-bottom nm-content">
+        <% if aca_security_questions %>
+          <%= render 'users/security_question_responses/modal' %>
+        <% end %>
+
+        <%= render_flash %>
+        <div class="container">
+          <%= yield :horizontal_status %>
+        </div>
+          <%= yield %>
+      </div>
+      <% if EnrollRegistry.feature_enabled?(:live_chat_widget) %>
+        <%= render "shared/customer_support/live_chat_widget" %>
+      <% end %>
+      <%= render partial: './ui-components/bs4/v1/footers/footer' %>
+      <% if EnrollRegistry.feature_enabled?(:jquery_migrate) %>
+        <% if EnrollRegistry[:jquery_migrate].setting(:show_warnings).item == true %>
+          <script src="https://code.jquery.com/jquery-migrate-3.4.1.js"></script>
+        <% else %>
+          <script src="https://code.jquery.com/jquery-migrate-3.4.1.min.js"></script>
+        <% end %>
+      <% end %>
+    </body>
+  </html>
+<% end %>
diff --git a/components/financial_assistance/app/assets/javascripts/financial_assistance/benefit.js b/components/financial_assistance/app/assets/javascripts/financial_assistance/benefit.js
@@ -105,7 +105,6 @@ document.addEventListener("turbolinks:load", function() {
     clonedForm.querySelector('.insurance-kind-label').innerHTML = selected.innerHTML;
     clonedForm.querySelector('#benefit_insurance_kind').value = selected.value;
     clonedForm.removeAttribute('id');
-    console.log(select.value)
     clonedForm.classList.remove('hidden');
     clonedForm.classList.add(selected.value);
     clonedForm.classList.add('benefit');
@@ -559,7 +558,9 @@ document.addEventListener("turbolinks:load", function() {
           $('#add_new_benefit_kind_is_enrolled').removeClass('hidden');
         } else {
           $('#add_new_benefit_kind_is_enrolled').addClass('hidden');
-          startEditing($('#has_enrolled_health_coverage_true').closest(".driver-question"));
+          if ($("body").data('bs4')) {
+            startEditing($('#has_enrolled_health_coverage_true').closest(".driver-question"));
+          }
         }
       } else{
         $("#enrolled-benefit-kinds").addClass('hide');

diff --git a/...nts/financial_assistance/app/assets/javascripts/financial_assistance/step_conditionals.js b/...nts/financial_assistance/app/assets/javascripts/financial_assistance/step_conditionals.js
@@ -7,8 +7,13 @@ document.addEventListener("turbolinks:load", function() {
   });
 
   /* attestations */
-  $('#living_outside_yes, #living_outside_no').change(function(e) {
-    $('#application_attestation_terms').attr('required', e.target.value == 'true');
+  $('#living_outside_yes, #living_outside_no').off('change')
+  $('#living_outside_yes, #living_outside_no').on('change', function(e) {
+    if ($('#living_outside_yes').is(':checked')) {
+      $('#application_attestation_terms').attr('required', true);
+    } else {
+      $('#application_attestation_terms').removeAttr('required');
+    }
   });
 
   if ($('#medicaid_pregnancy_yes').length) {
@@ -546,7 +551,6 @@ $(document).ready(function(){
     living_outside_checked = living_outside_no || (living_outside_yes && attestation_terms)
     signature_valid = (first_name_thank_you == subscriber_first_name) && (last_name_thank_you == subscriber_last_name)
     checks_complete = boxes_checked && living_outside_checked && signature_valid
-
     if(checks_complete){
       $('.interaction-click-control-submit-application').removeClass('disabled');
     } else {

diff --git a/...ents/financial_assistance/app/controllers/financial_assistance/applications_controller.rb b/...ents/financial_assistance/app/controllers/financial_assistance/applications_controller.rb
@@ -125,11 +125,10 @@ def submit_your_application
       respond_to :html
     end
 
-    def submit
+    def submit_your_application_save
       raise ActionController::UnknownFormat unless request.format.html?
 
       authorize @application, :submit?
-
       if params[:application].present?
         @application.assign_attributes(permit_params(params[:application]))
 
@@ -150,7 +149,7 @@ def step
 
       authorize @application, :step?
 
-      if params[:id] == 1
+      if params[:step] == "1"
         redirect_to preferences_application_path(@application)
       else
         redirect_to submit_your_application_application_path(@application)
@@ -593,7 +592,6 @@ def submit_and_publish_application_redirect_path
       return { path: application_publish_error_application_path(@application), flash: { error: build_error_messages(@application) } } unless @application.complete?
 
       publish_result = determination_request_class.new.call(application_id: @application.id)
-
       return { path: wait_for_eligibility_response_application_path(@application), flash: nil } if publish_result.success?
 
       @application.unsubmit! if @application.may_unsubmit?

diff --git a/...nents/financial_assistance/app/views/financial_assistance/applicants/_applicants.html.erb b/...nents/financial_assistance/app/views/financial_assistance/applicants/_applicants.html.erb
@@ -20,11 +20,11 @@
       </div>
       <div>
         <label for="primary-gender"><%= l10n("gender")%></label>
-        <input id="primary-gender" type="text" value="<%= "#{@person.gender.humanize}" %>" disabled >
+        <input id="primary-gender" type="text" value="<%= "#{@person.gender&.humanize}" %>" disabled >
       </div>
       <div>
         <label for="primary-relation"><%= l10n("relationship")%></label>
-        <input id="primary-relation" type="text" value="<%= l10n("self").humanize %>" disabled >
+        <input id="primary-relation" type="text" value="<%= l10n("self")&.humanize %>" disabled >
       </div>
     </div>
 
@@ -99,7 +99,7 @@
       </div>
       <div class="col-md-3 col-sm-6 no-pd form-group-lg no-pd class-fa-household">
         <label class="static_label label-floatlabel" for="name"><%= l10n("gender").to_s.upcase %></label>
-        <span class="field_value floatlabel form-control active-floatlabel" id="name"><%= "#{@person.gender.humanize}" %></span>
+        <span class="field_value floatlabel form-control active-floatlabel" id="name"><%= "#{@person.gender&.humanize}" %></span>
       </div>
       <div class="col-md-3 col-sm-6 no-pd form-group-lg no-pd class-fa-household">
         <label class="static_label label-floatlabel" for="relation">RELATIONSHIP</label>
@@ -148,4 +148,4 @@
       <% end %>
     </div>
   </div>
-<% end %>
+<% end %>
-Original file line number
+Diff line change
@@ Expand Up / @@ -178,6 +178,7 @@ @@
                   </div>
                 </div>
               </div>
+            </div>
         </div>
       </div>
@@ Expand Down @@