sep effective on kinds fields inline fix (#4872)

* use keydown attr on zip text fields, move ajax script to js file * use data attr for select tag * fix label required asterisk --------- Co-authored-by: Ann Caballero <[email protected]>
ideacrew · Dec 25, 2024 · 1cbb3a3 · 1cbb3a3
1 parent 007f0ec
commit 1cbb3a3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/app/views/insured/families/_effective_on_kind_fields.html.erb b/app/views/insured/families/_effective_on_kind_fields.html.erb
@@ -1,10 +1,8 @@
 <% if @qle.effective_on_kinds.count > 1 %>
   <% if @bs4 %>
-    <div onkeydown="handleButtonKeyDown(event, 'qle_success_submit')">
-      <label class="weight-n required">
-        <div><%= l10n('please_select_effective_date') %></div>
-        <%= select_tag 'effective_on_kind', options_for_select(generate_options_for_effective_on_kinds(@qle, @qle_event_date)), include_blank: l10n("select"), class: "col-auto pr-4" %>
-      </label>
+    <div data-keydown-id='qle_success_submit'>
+      <label for="effective_on_kind" class="weight-n required"><%= l10n('please_select_effective_date') %></label>
+      <%= select_tag 'effective_on_kind', options_for_select(generate_options_for_effective_on_kinds(@qle, @qle_event_date)), include_blank: l10n("select"), class: "col-auto pr-4" %>
     </div>
   <% else %>
     <div class="alert alert-danger" id='qle_effective_on_kind_alert' role="alert" style='display:none'><%= l10n(".please_select_effective_date") %></div>

diff --git a/app/views/insured/families/check_move_reason.js.erb b/app/views/insured/families/check_move_reason.js.erb
@@ -25,7 +25,7 @@ function init_moving_fields(event) {
       }
     })
   <% end %>
-    
+
   $('#qle_zip_compare').on('click', function() {
     function handleFailure() {
       $('#qle_reason').hide();